sztosz

sztosz

Hi, somehow, after typing code from book i managed only to make my code stuck at infinite loop. I did comparision side by side of my code to that i get from zipped examples i got with book (code from zip works ok). I can’t find where did i do mistake. Can anyone spot what did do wrong? I know i can move on, i understand what is going on, but it’s driving me nuts, beside, there is a big chance i won’t repeat that mistake if only i would know where it is :frowning:

Anyway, here’s the code:

defmodule FibSolver do

  def fib(scheduler) do
    send(scheduler, { :read, self })
    receive do
      { :fib, n, client } ->
        send(client, { :answer, n, fib_calc(n), self })
        fib(scheduler)
      { :shutdown } ->
        exit(:normal)
    end
  end

  defp fib_calc(0), do: 0
  defp fib_calc(1), do: 1
  defp fib_calc(n), do: fib_calc(n-1) + fib_calc(n-2)
end

defmodule Scheduler do
  
  def run(num_processes, module, func, to_calculate) do
    (1..num_processes)
    |> Enum.map(fn(_) -> spawn(module, func, [self]) end)
    |> schedule_processes(to_calculate, [])
  end

  defp schedule_processes(processes, queue, results) do
    receive do
      { :ready, pid } when length(queue) > 0 ->
        [ next | tail ] = queue
        send(pid, { :fib, next, self })
        schedule_processes(processes, tail, results)
      { :ready, pid } ->
        send(pid, { :shutdown })
        if length(processes) > 1 do
          schedule_processes(List.delete(processes, pid), queue, results)
        else
          Enum.sort(results, fn {n1,_}, {n2,_} -> n1 <= n2 end)
        end
      { :answer, number, result, _pid } ->
        schedule_processes(processes, queue, [{ number, result } | results])
    end
  end
end

to_process = [37, 37, 37, 37, 37, 37]

Enum.each(1..10, fn num_processes ->
  { time, result } = :timer.tc(Scheduler, :run, [num_processes, FibSolver, :fib, to_process])
  if num_processes == 1 do
    IO.puts(inspect(result))
    IO.puts("\n #  time(s)")
  end
  :io.format("~2B     ~.2f~n", [num_processes, time/1000000.0])
  end)

Showing Posts 1 to 4

lionize

lionize

Looks like that should be {:ready, self}. Can’t start the circus if it’s never telling the Scheduler it’s ready. :slight_smile:

sztosz

sztosz OP

Thank you very much. Such typos are hard to spot, i normally rely on IDE to help me with them, but i have none for elixir :slight_smile:

I think the lesson for me is to also pattern match “anything” at end of receive and exit program printing the oddity I just catch, at least when I’m learning :wink:

PS. Func fact: Single core performance of my 1.6 Ghz i5 in mac book air (OSX) is better than single core performance of 3.7 Ghz AMD (Win10)

rvirding

rvirding

Creator of Erlang

Deciding what to do when you get a message in which you are not interested is a general problem. Should I crash, or should I ignore it, or what? Unfortunately there is no general solution which is good for everyone everywhere.

Just some philosophy.

Robert

Qqwy

Qqwy

TypeCheck Core Team

This is very true.

For completeness: When you use an OTP GenServer, it picks the ‘let it crash’ approach for you, as it will simply attempt to call a variant of handle_call, handle_cast or handle_info that does not exist. (Of course, when you don’t have, for instance, any overridden variants of handle_info, it will default to doing nothing with any info-messages it receives).

You can of course change it to the second variant by creating a fallback function variant that accepts any other message.

— All posts loaded —

Where Next? Top

Trending in Questions Top

water
I’m aware of 2 such projects, are there others? git: GitHub - team-alembic/realworld: A fullstack Phoenix LiveView application with back...
New
katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
bradley
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
unaware8150
Hello folks! So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
Alvinkariuki
How Can I Optimise Compile Time Dependencies I have been building an elixir application for about 2 years now. Many modules and files ha...
New

Other Trending Topics Top

budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
budgie
I love Elixir. It’s one of 2 programming languages I’ve ever fallen in love with. But I don’t use it anymore. Serverless was the promis...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews