Programming phoenix Chapter 3. Controllers page 54

How does this function look like? Do you have any calls to render/* there?

My UserController content:

defmodule RumblWeb.UserController do
  use RumblWeb, :controller

  alias Rumbl.Accounts

  def index(conn, _params) do
    users = Accounts.list_users()
    render(conn, "index.html", users: users)
  end

  def show(conn, %{"id" => id}) do
    user = Accounts.get_user(id)
    render(conn, "show.html", user: user)
  end
end

Also this is the UserView content:

defmodule RumblWeb.UserView do
  use RumblWeb, :view

  alias Rumbl.Accounts

  def first_name(%Accounts.User{name: name}) do
    name
    |> String.split(" ")
    |> Enum.at(0)
  end
end

:users is not @user, your index.html.eex is wrong.

OK the book is also wrong about that one. Because the content is like this for index.html.eex

<tr>
<td><%= render "user.html", user: user %></td>
<td><%= link "View", to: Routes.user_path(@conn, :show, user.id) %></td>
</tr>

Is it just that? I’d expect a for around that… Something like this:

<table>
<%= for user <- @users do %>
  <tr><td><%= render "user.html", user: user %></td></tr>
<% end %>
</table>

It uses the user.html.eex to get rid of duplication but to me it seems that it doesn’t work

The following code for index.html.eex doesn’t work but it compiles:

<tr>
<td><%= render("user.html", users: @users) %></td>
<td><%= link "View", to: Routes.user_path(@conn, :show, @users.id) %></td>
</tr>

The following doesn’t compile:

<tr>
<td><%= render("user.html", users: users) %></td>
<td><%= link "View", to: Routes.user_path(@conn, :show, users.id) %></td>
</tr>

user.html.eex is for a single user, but index (by convention) is for many. So you need to iterate over your many users and render them one by one.

I do not have access to the book. I can only tell you what I think is going on here.

This is the excerpt of the part we are talking about:

Nesting Templates
Often there’s a need to reduce duplication in the templates themselves. For ex-
ample, both of our templates have common code that renders a user. Take the
common code and 

create a user template in lib/rumbl_web/templates/user/user.html.eex:
<strong><%= first_name(@user) %></strong> (<%= @user.id %>)

We created another template to render a user. Then, whenever we build tables
or listings of users, we can re-use this template. Now, change your show.html.eex
template to render it:
<h1>Showing User</h1>
<%= render "user.html", user: @user %>

Also, change your index.html.eex template to render it:
<tr>
<td><%= render "user.html", user: user %></td>
<td><%= link "View", to: Routes.user_path(@conn, :show, user.id) %></td>
</tr>

Yes, "user.html.eex" seems to be fine. As I said already… There is a loop missing in index.html.eex.

I’m pretty sure, the book already had a loop and wants you to replace the loops body with the snippet you show, while you replaced the full content.

That makes sense I will do that the original loop is this one:

Or here https://media.pragprog.com/titles/phoenix14/code/controllers_views_templates/listings/rumbl/lib/rumbl_web/templates/user/index.html.eex

<h1>Listing Users</h1>
<table>
<%= for user <- @users do %>
<tr>
<td><b><%= first_name(user) %></b> (<%= user.id %>)</td>
<td><%= link "View", to: Routes.user_path(@conn, :show, user.id) %></td>
</tr>
<% end %>
</table>