denvaar

denvaar

I’m not sure if this is the way things are intended to be, but I’ve noticed that the following modules (in a new mix project using erlang 26.1.2 & elixir 1.15.7) produce a cycle error:

defprotocol MyProto do
  @fallback_to_any true

  def foo(x)
end
defimpl MyProto, for: Any do
  def foo(_x), do: :any
end
defimpl MyProto, for: Specific do
  def foo(_x), do: :specific
end

mix xref graph --format cycles --label compile-connected --fail-above 0

1 cycles found. Showing them in decreasing size:

Cycle of length 3:

    lib/any.ex
    lib/my_proto.ex
    lib/any.ex

** (Mix) Too many cycles (found: 1, permitted: 0)

So, is this intended behavior? If so, what’s the best way to ignore it? Otherwise, can someone explain why it’s expected?

Showing Posts 1 to 5

sodapopcan

sodapopcan

Using your exact example, and a few variations of it, I am unable to reproduce this. Does this happen for you with this exact code or is there more to it?

More generally, I think --fail-above 0 is pretty aggressive. Some things are inherently cyclical and so long as you can keep “boundaried” off it’s all good (think db schemas with belongs_to and has_many). Of course I know nothing of your project so I’m just blabbing here.

denvaar

denvaar OP

https://github.com/denvaar/protocol_bug_demo

with erlang 26.1.2 and elixir 1.15.7

sodapopcan

sodapopcan

Thanks for the repo! I was testing mostly in one file.

So TL;DR, move the impl for Any to the same file as the defprotocol and you’re good.

In terms of why this is, hopefully someone else can explain as I’m interested myself. I have an inkling but I don’t want to make stuff up (at least not this time :upside_down_face:)

Of note:

  • 1.18.2 only produces a cycle length of 2. I’ve helped nuke compiled time deps in a few projects over the past few years and each new version of Elixir makes good strides in eliminating unnecessary deps.

  • Practically speaking, in both 1.15 and 1.18, it’s only when you change the Any implementation that every file that implements the protocol will be triggered. This is expected and will happen regardless of where you have defined Any.

sodapopcan

sodapopcan

I looked into it a little bit and I’m assuming it’s this line. This is going to create a compile time dep on the module defined by defprotocol and then of course that module needs to know about the protocol module. I also didn’t realize until I tried it out that in general so long as two modules are defined in the same file then no compile time dep is created between them, so that would explain that.

LostKobrakai

LostKobrakai

The elixir compiler works on a per file basis. So there’s simply no need to track and dependencies between things in a single file.

— All posts loaded —

Where Next? Top

Trending in Questions Top

Blokh
Hey guys, I’ve got a huge CSV ( around 10 GB ) that needs to be processed hourly Do you guys have any suggestions what is the best prac...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
psy-q
I’m trying to set up Emacs with elixir-ls via lsp-mode and credo via Flycheck. This should mostly be preconfigured as Flycheck picks up c...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews