Andres

Andres

Reverse an integer regardless of its sign

Hello.

Trying to reverse an integer regardless of its sign I wrote the following algorithm:

int = -123456789 #=> Expected result -987654321

def minus_one(int) do
    int * -1
end

def sign(int) when int > 0 do
    int
    |> Integer.to_string()
    |> String.reverse()
    |> String.to_integer()
end

def sign(int) do
    int
    |> Integer.to_string()
    |> String.replace("-", "")
    |> String.reverse()
    |> String.to_integer()
    |> minus_one()
end

def reverse_integer(int) do
    sign(int)
end

Is there a native way to get the sign of a number? like :math.sign()

Any suggestions to improve the algorithm is welcome.

Thanks.

Marked As Solved

NobbZ

NobbZ

Why converting to a string at all?

Just do the maths:

defmodule DR do
  def r(n), do: r(n, 0)

  def r(0, x), do: x
  def r(n, x), do: r(div(n, 10), x * 10 + rem(n, 10))
end

Also Liked

Eiji

Eiji

@Andres: I can see much simpler way:

defmodule Example do
  def sample(integer) when is_integer(integer) do
    integer |> Integer.digits() |> Enum.reverse() |> Integer.undigits()
  end
end

Is that what you wanted?

Edit: Code changed after @Ted comment

Eiji

Eiji

Originally I noticed this on other data too, but I found that it is not a problem in this specific case, because as far as I know Integer.digits/1 will never return list like [1, -2, 3].

There is nothing surprising with 83 as result, because we have: (3 * 10^0) + (-2 * 10^1) + (1 * 10^2) i.e. (3 * 1) + (-2 * 10) + (1 * 100) i.e. 3 - 20 + 100 which gives 83.

LostKobrakai

LostKobrakai

def sign(int) when int >= 0, do: 1
def sign(int) when int < 0, do: -1
        
def reverse(int) when int >= 0 do
    int
    |> Integer.to_string()
    |> String.reverse()
    |> String.to_integer()
end
    
def reset_sign(int, 1), do: int
def reset_sign(int, -1), do: int * -1

def reverse_integer(int) do
    int
    |> abs()
    |> reverse()
    |> reset_sign(sign(int))
end

Where Next?

Popular in Questions Top

lastday4you
I wanted to check elixir version in phoenix because i found that my elixir is 1.5 but when i use Enum.chunk_by it said the function is un...
New
mgjohns61585
Could someone help me? I’m making my first elixir program, number guessing game. I can’t figure out how to convert the user’s guess from ...
New
johnnyicon
Hi all, I’ve just started learning Elixir and Phoenix Framework, so please pardon my n00bness at this stage. I’m trying to use Postgres...
New
JorisKok
I have a server on AWS, and was running a load test using artillery. When looking at the Phoenix dashboard I see the Ports going to 100% ...
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New
stefanluptak
Hello everybody, usually, I use a 29" ultra-wide monitor for VSCode which can easily accomodate explorer (files panel) + file with code ...
New
belgoros
I’m not a pro in using Regex and can’t figure out why the following behaviour happens, especially if we take into account the difference ...
New
itssasanka
Hi all, Trying to get some more clarity over utc_datetime and naive_datetime for Ecto: The documentation above suggests that while ...
New
sergio_101
I am VERY much an elixir newbie. I have taken one elixir course and one phoenix course on Udemy. During that course, I saw the instructor...
New
PeterCarter
There are pre-rolled solutions for other frameworks that do work. However, Phoenix does not seem to have these. Have people had good expe...
New

Other popular topics Top

Darmani72
If I have a post route which an argument: post /my_post_route/:my_param1, MyController.my_post_handler How would get the post params ...
New
9mm
I am constructing a JSON object (map) and I need to conditionally set a field. I’m trying to write proper elixir-way code… and I’m at a l...
New
siddhant3030
Hi, I have to write a raw query for one of my project. But till now I have used ecto queries and don’t have much experience writing raw ...
New
Nvim
Anybody knows a comprehensive comparison of Django and Phoenix, thanks for the help. Where are they similar? Where do they differ the m...
New
lessless
I believe there are people here who are dealing with CSV files import on the daily basis, and since Excel is a really popular tool there ...
New
ovidiubadita
Hey all, I discovered Elixir and I love it. I always wanted to learn a functional programming and I intended to go for Haskell, but afte...
New
AstonJ
Please see the new poll here: Which code editor or IDE do you use? (Poll) (2022 Edition) It’s been a while since we first asked this, I...
208 31142 143
New
jason.o
In the code below, if the create action is not set to accept “extra_key” as an input, it errors out with a message shown above. Is there ...
New
WestKeys
Currently suffering from paralysis by [HTTP client] analysis. This is rather unusual in Elixirland as there tends to be consensus on the ...
New
jononomo
For some reason my phoenix channels are working for me in my local dev environment, but as soon as I deploy via Docker, I get a 403 error...
New

We're in Beta

About us Mission Statement