przemyxe0p
Hi,
I am wondering why my solution wil not work
1. source: Perfect Numbers in Elixir on Exercism
2. solution attempt:
@spec classify(number :: integer) :: {:ok, atom} | {:error, String.t()}
def classify(number) do
case aliquot_sum(number) do
number -> ok(:perfect)
x when x > number -> ok(:abundant)
x when x < number -> ok(:deficient)
end
end
defp ok(item), do: {:ok, item}
defp aliquot_sum(number), do: get_divisors(number) |> Enum.sum()
defp get_divisors(number, divisor \\ 1, acc \\ [])
defp get_divisors(number, divisor, acc) when divisor > div(number,2), do: acc
defp get_divisors(number, divisor, acc) when rem(number, divisor) == 0,
do: get_divisors(number, divisor + 1, [divisor | acc])
defp get_divisors(number, divisor, acc), do: get_divisors(number, divisor + 1, acc)
end
3. question:
Complier is saying:
this clause cannot match because a previous clause at line 15
always matchesElixir
perfect_numbers.ex(15, 7): related
and
variable "number" is unused (there is a variable with the same name in the
context, use the pin operator (^) to match on it or prefix this variable
with underscore if it is not meant to be used)Elixir
Why is that, why it cannot match with number passed to function?
Where Next?
Trending in Questions
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
Hi everyone.
My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
Hello,
I’m trying to build a basic Phoenix web-app, and I’d like to use Tailwind.
However, when I launch mix phx.server, I get an error...
New
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
Hello folks!
So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
How Can I Optimise Compile Time Dependencies
I have been building an elixir application for about 2 years now. Many modules and files ha...
New
Other Trending Topics
A little off-topic, but I feel like people here have a good head on their shoulders.
I used to be quite good at making software. Was luc...
New
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
I love Elixir. It’s one of 2 programming languages I’ve ever fallen in love with.
But I don’t use it anymore.
Serverless was the promis...
New
Latest on Elixir Forum
Sponsor Spotlight
Catch errors, track performance, monitor hosts and more.
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #library
- #deployment
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #discussion
- #code-sync
- #podcasts
- #javascript
- #onsite
- #dialyzer
- #docker
- #authentication
- #ai
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #blog-post
- #elixirconf-us
- #elixir-ls
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #elixirconf-eu
- #api
- #forms
- #security
- #metaprogramming
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Error tracking, logs, uptime, and Just Enough APM. Built for developers.
Master modern tools, write cleaner code, and tackle real-world challenges.
Bringing learning, work and compliance together since 1987.
The deployment platform built for Elixir: PaaS ease, VPS control.
The team behind Membrane, Popcorn, LiveDebugger. Available for hire.
Courses that'll move you from confusion to "Aha, now I get it!"
Showing Posts 1 to 10- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
krasenyp
The first case clause matches any number. The clauses’ order matters.
przemyxe0p
But I used the same variable name in function clause, so I would expect that It would match against it
krasenyp
Oh, I get you now. You can use the pin operator
^number.kokolegorille
No, your logic is wrong and number might not be what You think…
As soon as there is a match, the rest of the case is discarded
the number in the case is not the number parameter, it is a new number
You probably should write this with cond
przemyxe0p
After adding ^ operator it’s right why should I use cond? What is more “idiomatic” whatever this “idiomatic” word mean?
kokolegorille
Because it’s very rare to use ^number in the case
Yet, You can do as You like
krasenyp
In my experience it’s very rare to use
condbut it’s still valid.przemyxe0p
Last question, i cannot find explanatio why this works that way. Do you have explanation or link to resources?
krasenyp
sodapopcan
People have a weird aversion to
condfor some reason that I don’t really understand. Doing pure boolean checks is exactly what it exists for. Thecaseversion is essentially the same with unnecessary extra syntax. Usingcondgives added information that indeed all clauses are boolean checks. It’s only rare because this doesn’t come up as often in Elixir, but it certainly does come up!