przemyxe0p

przemyxe0p

Hi,
I am wondering why my solution wil not work

1. source: Perfect Numbers in Elixir on Exercism

2. solution attempt:

  @spec classify(number :: integer) :: {:ok, atom} | {:error, String.t()}
  def classify(number) do
    case aliquot_sum(number) do
      number -> ok(:perfect)
      x when x > number -> ok(:abundant)
      x when x < number -> ok(:deficient)
    end
  end

  defp ok(item), do: {:ok, item}
  defp aliquot_sum(number), do: get_divisors(number) |> Enum.sum()

  defp get_divisors(number, divisor \\ 1, acc \\ [])
  defp get_divisors(number, divisor, acc) when divisor > div(number,2), do: acc
  defp get_divisors(number, divisor, acc) when rem(number, divisor) == 0,
    do: get_divisors(number, divisor + 1, [divisor | acc])
  defp get_divisors(number, divisor, acc), do: get_divisors(number, divisor + 1, acc)
end

3. question:

Complier is saying:

this clause cannot match because a previous clause at line 15
always matchesElixir
perfect_numbers.ex(15, 7): related

and

variable "number" is unused (there is a variable with the same name in the
context, use the pin operator (^) to match on it or prefix this variable 
with underscore if it is not meant to be used)Elixir

Why is that, why it cannot match with number passed to function?

Showing Posts 1 to 10

krasenyp

krasenyp

The first case clause matches any number. The clauses’ order matters.

przemyxe0p

przemyxe0p OP

But I used the same variable name in function clause, so I would expect that It would match against it

krasenyp

krasenyp

Oh, I get you now. You can use the pin operator ^number.

kokolegorille

kokolegorille

No, your logic is wrong and number might not be what You think…

As soon as there is a match, the rest of the case is discarded

the number in the case is not the number parameter, it is a new number

You probably should write this with cond

aliquot = aliquot_sum(number)
cond do
  aliquot > number -> ...
  aliquot < number -> ...
  aliquot == number -> ...
end
przemyxe0p

przemyxe0p OP

After adding ^ operator it’s right why should I use cond? What is more “idiomatic” whatever this “idiomatic” word mean? :smiley:

kokolegorille

kokolegorille

Because it’s very rare to use ^number in the case :slight_smile:

Yet, You can do as You like

krasenyp

krasenyp

In my experience it’s very rare to use cond but it’s still valid.

przemyxe0p

przemyxe0p OP

Last question, i cannot find explanatio why this works that way. Do you have explanation or link to resources?

sodapopcan

sodapopcan

People have a weird aversion to cond for some reason that I don’t really understand. Doing pure boolean checks is exactly what it exists for. The case version is essentially the same with unnecessary extra syntax. Using cond gives added information that indeed all clauses are boolean checks. It’s only rare because this doesn’t come up as often in Elixir, but it certainly does come up!

Where Next? Top

Trending in Questions Top

Blokh
Hey guys, I’ve got a huge CSV ( around 10 GB ) that needs to be processed hourly Do you guys have any suggestions what is the best prac...
New
RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews