przemyxe0p
Hi,
I am wondering why my solution wil not work
1. source: Perfect Numbers in Elixir on Exercism
2. solution attempt:
@spec classify(number :: integer) :: {:ok, atom} | {:error, String.t()}
def classify(number) do
case aliquot_sum(number) do
number -> ok(:perfect)
x when x > number -> ok(:abundant)
x when x < number -> ok(:deficient)
end
end
defp ok(item), do: {:ok, item}
defp aliquot_sum(number), do: get_divisors(number) |> Enum.sum()
defp get_divisors(number, divisor \\ 1, acc \\ [])
defp get_divisors(number, divisor, acc) when divisor > div(number,2), do: acc
defp get_divisors(number, divisor, acc) when rem(number, divisor) == 0,
do: get_divisors(number, divisor + 1, [divisor | acc])
defp get_divisors(number, divisor, acc), do: get_divisors(number, divisor + 1, acc)
end
3. question:
Complier is saying:
this clause cannot match because a previous clause at line 15
always matchesElixir
perfect_numbers.ex(15, 7): related
and
variable "number" is unused (there is a variable with the same name in the
context, use the pin operator (^) to match on it or prefix this variable
with underscore if it is not meant to be used)Elixir
Why is that, why it cannot match with number passed to function?
Where Next?
Trending in Questions
Hello!
Suppose you are building workflow (order / task / payment) processing system with the following requirements:
Each workflow con...
New
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app?
Looking for hints regarding:
Addi...
New
Hi all, I wanted to ask how the community is dealing with post-release steps.
Today we have Ecto migrations, which make sure that the db...
New
Kia ora,
We have been using elixir-google-api to connect to Google Drive. However, with the updates to Tesla due to CVEs this is now bro...
New
Hello,
I have an Elixir backend that implements a custom protocol over TCP. I want to load test the backend and assess the performance o...
New
Other Trending Topics
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve.
They are GUI (Emerge) and State management (S...
New
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
Latest on Elixir Forum
Sponsor Spotlight
Error tracking, logs, APM, uptime and cron monitoring in one dev-friendly platform. Find and fix problems before your users notice.
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #blog-post
- #phoenix_html
- #iex
- #graphql
- #ai
- #genstage
- #elixirconf-us
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #metaprogramming
- #security
- #hex
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Error tracking, logs, uptime, and Just Enough APM. Built for developers.
Practical resources that improve the lives of professional developers.
Bringing learning, work and compliance together since 1987.
The deployment platform built for Elixir: PaaS ease, VPS control.
The team behind Membrane, Popcorn, LiveDebugger. Available for hire.
Courses that'll move you from confusion to "Aha, now I get it!"
First 10 of 13 Posts
krasenyp
The first case clause matches any number. The clauses’ order matters.
przemyxe0p
But I used the same variable name in function clause, so I would expect that It would match against it
krasenyp
Oh, I get you now. You can use the pin operator
^number.kokolegorille
No, your logic is wrong and number might not be what You think…
As soon as there is a match, the rest of the case is discarded
the number in the case is not the number parameter, it is a new number
You probably should write this with cond
przemyxe0p
After adding ^ operator it’s right why should I use cond? What is more “idiomatic” whatever this “idiomatic” word mean?
kokolegorille
Because it’s very rare to use ^number in the case
Yet, You can do as You like
krasenyp
In my experience it’s very rare to use
condbut it’s still valid.przemyxe0p
Last question, i cannot find explanatio why this works that way. Do you have explanation or link to resources?
krasenyp
sodapopcan
People have a weird aversion to
condfor some reason that I don’t really understand. Doing pure boolean checks is exactly what it exists for. Thecaseversion is essentially the same with unnecessary extra syntax. Usingcondgives added information that indeed all clauses are boolean checks. It’s only rare because this doesn’t come up as often in Elixir, but it certainly does come up!