pepicrft

pepicrft

Hi :wave:,

I upgraded to Elixir 1.18.0, and started getting type-checking warnings in the following module:

defmodule TestModule do
  @env Mix.env()

  def prod?() do
   @env == :prod
  end 
end

Because the types don’t match:

dynamic(:dev) == :prod

What’s a recommended way to tackle this scenario with the new set-theoretic types system in Elixir?

Showing Posts 1 to 6

benwilson512

benwilson512

Author of Craft GraphQL APIs in Elixir with Absinthe

In this particular case I would probably do it like this:

defmodule TestModule do
  if Mix.env() == :prod do
    def prod?(), do: true
  else
    def prod?(), do: false
  end
end
ruslandoga

ruslandoga

There still seems to be a problem when this function is being used with “boolean” operators, for example:

defmodule Types do
  def prod?, do: unquote(Mix.env() == :prod)

  def a_or_b do
    if Types.prod?() and :rand.uniform() > 0.5 do
      :a
    else
      :b
    end
  end
end

warns

    warning: the following conditional expression will always evaluate to dynamic(false):

        Types.prod?()

    typing violation found at:
    │
  9 │     if Types.prod?() and :rand.uniform() > 0.5 do
    │     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    │
    └─ lib/types.ex:9: Types.a_or_b/0

Rewriting the caller like this seems to work but …

  def a_or_b do
    if Types.prod?() do
      if :rand.uniform() > 0.5 do
        :a
      end
    end || :b
  end
josevalim

josevalim

Creator of Elixir

We will fix this on Elixir v1.18.1 We will make it so it only warns when comparing across different types.

dkarter

dkarter

@josevalim was this fix implemented?
Looks like there is still an issue with compile env in 1.18.1 (see screenshot below)

We use it more like this in our app to decide whether to start certain children in the supervision tree:

josevalim

josevalim

Creator of Elixir

The fix right now only works when comparing constants. Because you encapsulate it in a function, it no longer works, but it would work if you did @env == :dev.

hq1

hq1

welp:

  defmacro always(term) do
    quote do
      :erlang.phash2(1, 1) == 0 && unquote(term)
    end
  end

  def prod?, do: always(unquote(Mix.env() == :prod))
— All posts loaded —

Where Next? Top

Trending in Questions Top

Blokh
Hey guys, I’ve got a huge CSV ( around 10 GB ) that needs to be processed hourly Do you guys have any suggestions what is the best prac...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
matt-savvy
Anyone here using Honeybadger? My Honeybadger account is being overwhelmed with noise from some bots. Seeing a lot of Bandit.HTTPError...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews