smanza

smanza

Hello.
I practiced Elixir for few months now but every time I wonder about some code organisation and particularly with struct and business logic.

I don’t know if struct must only define simple data transformation and validation or should contains more complex and business logic instead of dedicated business logic module.

From one side I have the feeling than logic functions dealing with the struct should be in the same module. But from another side, those functions may requires calls to other business logics modules etc… So maybe the abstraction and responsibility is not well designed.

What do you think that should be belong into struct module ?

Thanks

Showing Posts 1 to 7

mbuhot

mbuhot

Complex structs like %DateTime{} are a good example where the external users are discouraged from pattern matching directly on the struct fields, and should use the functions provided by the module to transform the value.

For Ecto shemas I like to put the functions that produce changesets in the schema module, then the higher level business logic that manages the transaction scope in context module function, or even a dedicated module for handling each command.

smanza

smanza OP

So you recommend using functions in struct for data transformation not for logic using it , like high level business logic dealing with other context modules ?

mbuhot

mbuhot

Yes that’s the approach I follow.
Declare data structures and the functions to transform them in the same module.
Then separately the business use cases in other modules.

Domain Modelling Made Functional is a good reference on organising code with domain models and workflows.

smanza

smanza OP

Thanks, I also was thinking about this approach.
I will look at it to see if it suits well.

smanza

smanza OP

Do you think struct functions must only be pure ( without side effect: genserver, ets, database call) ? And reserve those to more statefull modules or business workflow modules ?

mbuhot

mbuhot

Do you think struct functions must only be pure

For application code, that’s probably a good rule to follow, it aligns with the ‘functional core, imperative shell’ architecture style.

However for library code, there are examples where it doesn’t apply:

Plug.Conn is mostly pure functions, but it also contains the necessary functions like read_body and send_resp which aren’t pure.

Ecto.Changeset has unsafe_validate_unique that makes a DB call while most other validations are pure.

dimitarvp

dimitarvp

Mostly yes but don’t get religious about it. It’s okay for your business logic functions to depend on Ecto and Plug which have stateful (impure) parts. Utilise some tooling (like the boundaries library by @sasajuric) to check for dependencies you don’t want to allow but outside of that, don’t sweat too much about it. :slight_smile:

— All posts loaded —

Where Next? Top

Trending in Discussions Top

AstonJ
As the title says, please share what you’ve been up to with Elixir. Whether that’s been learning it, looking into it, making stuff with i...
2977 92995 915
New
caslu
I want to open this thread for you all to discuss and help those who really like Ash but are still hesitant to use it in a real project. ...
New
mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
GES233
I’m posting this in response to Jose’s recent tweet (Cr. link) : People are sleeping on Elixir for a coding harness: Hot-code swappi...
New
_mfierro
Hello, I wrote Stop My Hand, a Scattergories-like web application using Phoenix/LiveView as my learning project for Elixir (after readin...
New
marciol
It would be helpful to have a list of companies worldwide that hire engineers without prior experience in Elixir. Often, it can be quite ...
New
durvia
Anyone running long-lived stateful processes on BEAM? We’re building an AI agent runtime and would love to compare notes. We’re a small ...
New

Other Trending Topics Top

garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
wintermeyer
There are three potential reasons for members of this forum to have a look at https://vutuv.de You are tired or annoyed of LinkedIn. Yo...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews