david234
I am working on a code that will ping an external API every 15 minutes, to retrieve the response and store it in the database.
def get_forecast(city) do
app_id = My.api_key()
query_params = URI.encode_query(%{"q" => city, "APPID" => app_id})
url =
"https://api.weather.org/data/2.5/forecast?" <> query_params
case HTTPoison.get(url) do
{:ok, %HTTPoison.Response{status_code: 200} = response} ->
{:ok, Jason.decode!(response.body)}
{:ok, %HTTPoison.Response{status_code: status_code}} ->
{:error, {:status, status_code}}
{:error, reason} ->
{:error, reason}
end
end
I am running this inside a Task, and that Task is running inside a Genserver.
In application.ex
use Application
def start(_type, _args) do
children = [
# Starts a worker by calling: FsiIntegration.Worker.start_link(arg)
# {FsiIntegration.Worker, arg}
{Task.Supervisor, name: Integration.TaskSupervisor, restart: :transient, max_restarts: 3, max_seconds: 4000}
]
# See https://hexdocs.pm/elixir/Supervisor.html
# for other strategies and supported options
opts = [strategy: :one_for_one, name: Integration.Supervisor]
Supervisor.start_link(children, opts)
end
In genserver file
defmodule Integration.FsiServer do
use GenServer
@timeout 15000
#Public API
def start_task do
GenServer.start_link(__MODULE__, %{ref: nil}, name: __MODULE__)
end
def execute_task(pid) do
GenServer.call(pid, {:execute, @timeout})
end
#Callbacks API
def init(state) do
{:ok, state}
end
# In this case the task is already running, so we just return :ok.
def handle_call({:execute, _task_timeout}, _from, %{ref: ref} = state) when is_reference(ref) do
{:reply, :ok, state}
end
# The task is not running yet, so let's start it.
def handle_call({:execute, task_timeout}, _from, %{ref: nil} = state) do
IO.inspect state
task =
Task.Supervisor.start_child(Integration.TaskSupervisor, fn ->**
{:ok, _} = IntegrationGet.get_forecast("city")**
end)
{:reply, :ok, %{state | ref: task.ref}}
end
# The task completed successfully
def handle_info({ref, answer}, %{ref: ref} = state) do
Process.demonitor(ref, [:flush])
{:noreply, %{state | ref: nil}}
end
# The task failed
def handle_info({:DOWN, ref, :process, _pid, _reason}, %{ref: ref} = state) do
{:noreply, %{state | ref: nil}}
end
end
My questions are :
I know I have to improve on the below code. Can you guys me insight on how to make this better
use Application
def start(_type, _args) do
children = [
# Starts a worker by calling: FsiIntegration.Worker.start_link(arg)
# {FsiIntegration.Worker, arg}
{Task.Supervisor, name: Integration.TaskSupervisor, restart: :transient, max_restarts: 3, max_seconds: 4000}
]
# See https://hexdocs.pm/elixir/Supervisor.html
# for other strategies and supported options
opts = [strategy: :one_for_one, name: Integration.Supervisor]
Supervisor.start_link(children, opts)
end
def handle_call({:execute, task_timeout}, _from, %{ref: nil} = state) do
IO.inspect state
task =
Task.Supervisor.start_child(Integration.TaskSupervisor, fn ->
{:ok, _} = IntegrationGet.get_forecast("city")
end)
{:reply, :ok, %{state | ref: task.ref}}
end
-
The time interval between restarts I have set max_seconds to 5 seconds. But the restart happens immediately.
-
Is Task.Supervisor.start_child is good for making an external API request. Just it will make a single API request in this case. Or I have to go for async_nolink or async under Task module
My use case is request an external API and store the response in the DB.
Trending in Discussions
As the title says, please share what you’ve been up to with Elixir. Whether that’s been learning it, looking into it, making stuff with i...
New
I want to open this thread for you all to discuss and help those who really like Ash but are still hesitant to use it in a real project. ...
New
I am happy to introduce the very α version of the new programming language compiled to BEAM.
Welcome Cure.
It has literally three kille...
New
I’m posting this in response to Jose’s recent tweet (Cr. link) :
People are sleeping on Elixir for a coding harness:
Hot-code swappi...
New
Hello,
I wrote Stop My Hand, a Scattergories-like web application using Phoenix/LiveView as my learning project for Elixir (after readin...
New
It would be helpful to have a list of companies worldwide that hire engineers without prior experience in Elixir. Often, it can be quite ...
New
Anyone running long-lived stateful processes on BEAM? We’re building an AI agent runtime and would love to compare notes.
We’re a small ...
New
Other Trending Topics
Hobbes is a low-level distributed database for the Elixir programming language.
Hobbes provides a simple, safe, and scalable storage lay...
New
Hi there! We created Gust: A task orchestrator inspired by Airflow.
For those who have never heard about Aiflow, it’s a Python-based wor...
New
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve.
They are GUI (Emerge) and State management (S...
New
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
There are three potential reasons for members of this forum to have a look at https://vutuv.de
You are tired or annoyed of LinkedIn.
Yo...
New
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #discussion
- #code-sync
- #podcasts
- #javascript
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #blog-post
- #elixirconf-us
- #elixir-ls
- #ai
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #hex
- #security
- #metaprogramming










Showing Posts 1 to 4- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
kwando
The
max_restartsandmax_secondsoptions only states how many (max_restarts) restarts of a child in a time period of time (max_seconds) the supervisor should tolerate before crashing.You can read about
max_secondshere: Supervisor — Elixir v1.20.2.andreaseriksson
I like option 3 here:
But with the part of handling a failure, I would put in a sleep
LostKobrakai
sleepwill block the process from handling anything else in the meantime. It’s usually better to usesent_intervalto receive another message at a later time to trigger the restart, but staying responsive to other messages.andreaseriksson
True, 100% agree. Was in ruby land for a moment