polypush135

polypush135

Timex parsing invalid dates and the db is blowing up

Thoughts on how I can catch this type of error? I have an invalid date ie 11/31/2910. There is no 31st day of November. But my little logic does not catch that and timex seems to parse it all the same.

pry(2)> Timex.parse(start_date_string, "%m/%d/%Y", :strftime)
{:ok, ~N[2910-11-31 00:00:00]}

Heres my changeset validation gate

def parse_date(cs, key, string) do
    case Timex.parse(string, "%m/%d/%Y", :strftime) do
      {:ok, date} ->
        cs |> put_change(key, date)

      {:error, _} ->
        cs |> add_error("#{key}_string" |> String.to_atom(), "not a valid date")
    end
  end

but as I said since timex parses the date it passes the gate on its way to the db where it blows up

[error] #PID<0.567.0> running BeffectWeb.Endpoint terminated
Server: localhost:4000 (http)
Request: POST /departments/early-childhood/safe-and-together/client/1/spi/1
** (exit) an exception was raised:
    ** (ErlangError) Erlang error: :if_clause
        (stdlib) calendar.erl:117: :calendar.date_to_gregorian_days/3
        (ecto) Ecto.Adapters.Postgres.TypeModule.encode_params/3
        (postgrex) lib/postgrex/query.ex:45: DBConnection.Query.Postgrex.Query.encode/3
        (db_connection) lib/db_connection.ex:1079: DBConnection.describe_run/5
        (db_connection) lib/db_connection.ex:1150: anonymous fn/4 in DBConnection.run_meter/5
        (db_connection) lib/db_connection.ex:592: DBConnection.prepare_execute/4
        (ecto) lib/ecto/adapters/postgres/connection.ex:86: Ecto.Adapters.Postgres.Connection.execute/4
        (ecto) lib/ecto/adapters/sql.ex:256: Ecto.Adapters.SQL.sql_call/6
        (ecto) lib/ecto/adapters/sql.ex:542: Ecto.Adapters.SQL.struct/8
        (ecto) lib/ecto/repo/schema.ex:547: Ecto.Repo.Schema.apply/4
        (ecto) lib/ecto/repo/schema.ex:292: anonymous fn/14 in Ecto.Repo.Schema.do_update/4
        (ecto) lib/ecto/repo/schema.ex:774: anonymous fn/3 in Ecto.Repo.Schema.wrap_in_transaction/6
        (ecto) lib/ecto/adapters/sql.ex:576: anonymous fn/3 in Ecto.Adapters.SQL.do_transaction/3
        (db_connection) lib/db_connection.ex:1283: DBConnection.transaction_run/4
        (db_connection) lib/db_connection.ex:1207: DBConnection.run_begin/3
        (db_connection) lib/db_connection.ex:798: DBConnection.transaction/3
        (beffect) lib/beffect_web/controllers/spi_controller.ex:156: BeffectWeb.SPIController.update/2
        (beffect) lib/beffect_web/controllers/spi_controller.ex:1: BeffectWeb.SPIController.action/2
        (beffect) lib/beffect_web/controllers/spi_controller.ex:1: BeffectWeb.SPIController.phoenix_controller_pipeline/2
        (beffect) lib/beffect_web/endpoint.ex:1: BeffectWeb.Endpoint.instrument/4

What should I do for this?

Most Liked

axelson

axelson

Scenic Core Team

I think part of the problem is that Timex.parse/3 is only returning a NaiveDateTime when you’ll probably want a DateTime.

This is slightly improved:

iex(6)> Timex.parse!("11/31/2910", "%m/%d/%Y", :strftime) |> Timex.to_datetime("America/Chicago")
** (ErlangError) Erlang error: :if_clause
    (stdlib) calendar.erl:117: :calendar.date_to_gregorian_days/3
    (stdlib) calendar.erl:138: :calendar.datetime_to_gregorian_seconds/1
    (timex) lib/datetime/helpers.ex:32: Timex.DateTime.Helpers.construct/2

Although it seems that Timex should be returning an {:error, term()} instead of raising that Erlang error. Maybe that’s a bug in Timex?

michalmuskala

michalmuskala

Yeah, this looks like a bug in timex to me. IMHO it should never allow creating invalid dates when parsing.

Where Next?

Popular in Questions Top

Darmani72
If I have a post route which an argument: post /my_post_route/:my_param1, MyController.my_post_handler How would get the post params ...
New
fireproofsocks
Forgive me if this is obvious, but how does one delete a database record WITHOUT selecting it first? Ecto.Repo — Ecto v3.14.0 has exampl...
New
JorisKok
I have a server on AWS, and was running a load test using artillery. When looking at the Phoenix dashboard I see the Ports going to 100% ...
New
dokuzbir
I want to highlight html closing tags when i click a html tag. That works in .html files but doesnt work for html.eex templates. How can...
New
stefanluptak
Hello everybody, usually, I use a 29" ultra-wide monitor for VSCode which can easily accomodate explorer (files panel) + file with code ...
New
aalberti333
As the title describes, I’m trying to run Enum.map() over a list of key/value pairs, where the value is a map. My data looks like this: ...
New
lucidguppy
I have a super simple question about elixir - how would I take a file like this foo bar baz and output a new file that enumerates th...
New
fayddelight
I tried installing elixir 1.11.2 erlang 23.3.4 via asdf in my zsh shell. Enabled the versions locally and globally. When I list them ...
New
jason.o
In the code below, if the create action is not set to accept “extra_key” as an input, it errors out with a message shown above. Is there ...
New
chensan
I have a User schema with a :from_id field set to type :string: defmodule TweetBot.Repo.Migrations.CreateUsers do use Ecto.Migration ...
New

Other popular topics Top

sen
Hi All, I set a environment variables in dev.exs , like below code. when i start server, how can i set the ${enable} value? thanks. d...
New
sorentwo
Hello! tl;dr Announcing Oban, an Ecto based job processing library with a focus on reliability and historical observability. After spen...
985 42920 311
New
mcarvalho
What is the difference between System.get_env and Application.get_env? For example, what are best practices to use one versus another.
New
JeremM34
Hello, how can I check the Phoenix version ? Thanks !
New
jerry
Good day to you all. I have been struggling to get a query involving like and ilike to work. Can anyone assist me on this, please? pro...
New
chrismccord
This release brings a number of exciting features, including integration with the new Phoenix LiveDashboard and Phoenix LiveView. There h...
New
stefanchrobot
What’s the safe way to decode a JSON string into a struct? I want to avoid calling String.to_atom. Jason.decode can give me a map with st...
New
Qqwy
Original source of discussion: This topic on the Pragmatic Programmers’ Functional Web Development with Elixir, OTP, and Phoenix forum. ...
New
saif
Hello everyone, Long time lurker first time poster here. I’ve recently begun working on Elixir full-time again! :raised_hands: It’s been...
New
hariharasudhan94
Lets say I have map like this fetching from my database %{"_id" =&gt; #BSON.ObjectId&lt;58eb1a7a9ad169198c3dXXXX&gt;, "email" =&gt; ...
New

Latest on Elixir Forum

We're in Beta

About us Mission Statement