Oliver
Turning case-do up to 11
Hi.
I’m always looking for ways to make code more manageable, readable, and nice to look at. To this end, matching and the case-do statement have become my favorite tools in doing so.
I often found myself writing code like this:
case condition1 do
match1 -> case condition2 do
match2 -> ...
I tried pulling out the inner case-do into a function but that wasn’t “pretty” by any standard in a lot of cases. (In some cases it was definitely needed - one size doesn’t fit all.)
What I do these days looks more like this:
case {condition1, condition2} do
{match1, match2} -> ...
{match1, _} -> ...
{_, match2} -> ...
_ -> ...
end
The only thing I don’t like about this is that you have to repeat sometimes the result of one case in another. Just putting it in front of the case statement makes you compute something that might not be needed. You also cannot emulate this:
case condition1 do
match1 -> common = ...
case condition2 do
match2 -> <do something with common>
match3 -> <do something with common>
So, combining a case-do with tuples is no panacea. But it can clean up some code considerably.
Though you could do this…
common = fn -> <something common> end
case {condition1, condition2} do
{match1, match2} -> common.() ...
{match1, match3} -> common.() ...
{match1, _} -> ...
{_, match2} -> ...
_ -> ...
end
Hmmm..
Any additional ideas are very welcome!
Most Liked
NobbZ
Oliver
The biggest use of that I see is that it replicates the clean code you get from using the Maybe monad in Haskell-likes. As long as your functions fail by returning something emulating a Maybe - so basically {:ok, result} and {:error, result} and you use when to compute all the expensive parts, then you can basically reap the benefits of Maybe without implementing a new construct for it.
with {:ok, phase1} <- expensive_computation(),
{:ok, phase2} <- read_something_from_db(phase1),
{:ok, phase3} <- do_a_file_operation(phase2) do
phase3
else
:error -> :error
end
[EDIT: Fixed the operator as suggested by @Qqwy]
I like that. ![]()
The purpose of a Maybe is to “fall through” a computation when any step fails, without forcing the user to riddle the code with error-handling after every step. I don’t know how efficient with/1 is in regard to going to the else branch but it sure matches the elegance of such code without much effort.
You even get to define your own pattern what constitutes a Maybe. It just needs to be conveniently match-able. The Erlang convention of using :ok and :error tuples is hard to beat in this regard.
So, I’ll definitely take with-do-else into how I write code in the future. Thanks!
Qqwy
Be warned that with {:ok, result} = something() and with {:ok, result} <- something() mean something different!
With <-, the else will be called when it is not matched (or, if there is no else, the non-matching result is passed on to the outside scope).
With =, a MatchError is raised instead.
Popular in Questions
Other popular topics
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #websockets
- #supervisor
- #advent-of-code
- #elixirconf-us
- #distillery
- #processes
- #forms
- #api
- #metaprogramming
- #security
- #performance








