mudasobwa

mudasobwa

Creator of Cure

If the code during compile phase conditionally relies on some config, the typing validation would yell at us while compiling. Consider the following code

defmodule TypeTest do
  foo = Application.compile_env(:my_app, :param, true)

  defp fun(arg) do
    case unquote(foo) do
      false -> {:error, arg}
      true -> {:ok, arg}
    end
  end
end

the compilation warns out with

warning: the following clause will never match:
    false
because it attempts to match on the result of:
    true
which has type:
    true

Unfortunately, the famous trick to fool dialyzer does not obviously work here.

  case :erlang.phash2(1, 1) do
    0 -> …
  end

Any idea of how I could have this warning suppressed? In my opinion, the above is more or less common usecase and the warning there is unlikely helpful.

Showing Posts 1 to 6

mudasobwa

mudasobwa OP

Creator of Cure

Apparently, at the time being this shuts the type checker up:

defmodule TypeTest do
  foo = Application.compile_env(:my_app, :param, true)

  defp fun(arg) do
    case [unquote(foo), not unquote(foo)] do
      [false, true] -> {:error, arg}
      [true, false] -> {:ok, arg}
    end
  end
end

This happens, because the list in the question becomes non_empty_list(boolean()). Just matching [foo] won’t work because the latter has a type non_empty_list(true).

LostKobrakai

LostKobrakai

You can also not generate the unreachable branches to begin with.

defmodule TypeTest do
  foo = Application.compile_env(:my_app, :param, true)

  if foo do
    defp fun(arg), do: {:error, arg}
  else
    defp fun(arg), do: {:ok, arg}
  end
end
mudasobwa

mudasobwa OP

Creator of Cure

Indeed, thanks!

grigorius

grigorius

A bit late to the conversation - but this solution will create the same complaint from the compiler →
typing violation found at:

Is there any way to make the compiler aware of other possibilities?

zorn

zorn

I ran into this today, and the way I solved it was to move the logic from a module attribute using compile_env to an inner-function call using Application.get_env.

# Old way
defmodule MyApp.SomeModule do
  @debug Application.compile_env(:my_app, [__MODULE__, :debug], false)

  def debug?, do: @debug
end

# New way
defmodule MyApp.SomeModule do
  def debug? do
    Application.get_env(:my_app, [__MODULE__, :debug], false)
  end
end
mudasobwa

mudasobwa OP

Creator of Cure

Yeah, but that’s not the isomorphic approach, because in the not-so-contrived example the code might rely on @debug value during compile time all the turtles down.

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kpanic
Hi everyone, I am toying with the idea of building a “match maker” for giving personal help to people that wants to start coding. I sta...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
asweet-confluent
I recently noticed that Elixir’s Logger defaults its primary log level to :debug when no :logger, :level application configuration is pre...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
mhanberg
Hi everyone! The first release candidate for the Expert language server project is now available! We’ve published a press release detai...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
webofbits
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself. My main conc...
#ai
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews