Typo in Programming Phoenix 1.4 Beta?

phoenix
Tags: #<Tag:0x00007f8ea123de80>

#1

On p. 38 of the book the example code uses “phx-hero” as shown below. However, to correctly display the example browser image you would need “jumbotron”.

<%= gettext "Welcome to %{name}!", name: "Rumbl.io" %>

Rumbl out loud.

Is this an oversight (if so happy to just flag for the authors!) or am I missing something?


#2

You aren’t using Phoenix 1.4 but an earlier version.

In 1.4 phoenix.css includes milligram 1.3.0 and later defines the phx-hero class.

https://github.com/phoenixframework/phoenix/blob/master/installer/templates/phx_assets/phoenix.css#L58

In 1.3.2 phoenix.css includes Bootstrap 3.3.5 which defines the jumbotron class.
https://github.com/phoenixframework/phoenix/blob/v1.3/installer/templates/phx_assets/phoenix.css#L9

I describe how to convert a 1.3.2 project from Brunch to webpack here - which also uses the new assets.


#3

Doh! Thank you for the links. Very helpful.