fireproofsocks
I’m using Dialyzer to check over some code that uses the mongodb package. I’ve got a function that abstracts the Mongo.insert_one/4 function and adds in some extra logging for certain conditions:
def insert(collection, args) do
case Mongo.insert_one(mongo_pid(), collection, args) do
{:ok, %Mongo.InsertOneResult{acknowledged: true, inserted_id: id}} ->
{:ok, %{"_id" => id}}
# Check for 11000 error (usually this means a duplicate)
{:error, %Mongo.WriteError{write_errors: [%{"code" => 11_000} | _]} = err} -> {:error, "Duplicate entry"}
{:error, err} -> {:error, err}
end
end
When I run dialyzer, I get the following error:
The pattern can never match the type.
Pattern:
{:error, _err = %Mongo.WriteError{:write_errors => [%{<<99, 111, 100, 101>> => 11000} | _]}}
Type:
:ok
| {:error,
%Mongo.Error{
:__exception__ => _,
:code => number(),
:host => binary(),
:message => binary()
}}
| {:ok,
%Mongo.InsertOneResult{
:acknowledged => false,
:inserted_id => nil | %BSON.ObjectId{:value => <<_::96>>}
}}
After looking at the mongodb source code I can see that it appears to miss a viable return type:
@type result(t) :: :ok | {:ok, t} | {:error, Mongo.Error.t()}
should be (I think) something like:
@type result(t) :: :ok | {:ok, t} | {:error, Mongo.Error.t()} | {:error, Mongo.WriteError.t()}
My questions are:
- Am I correct in thinking that the dialyzer error in my app is resulting from what appears to be an incorrect type definition in a dependency (
mongodbin this case)? - Apart from filing an issue, what are the ways to configure dialyzer to ignore that particular error in that specific place?
- Why doesn’t Dialyzer catch this problem in
mongodb? I cloned the repo, I fired up Dialyzer, and it shows no errors. Is that expected? Common?
Trending in Questions
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
Hello!
Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app.
I creat...
New
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
So my question is quite simple and i have found no conclusive answer on forum, google or AI.
Should we use :erlang.float for Integer to ...
New
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
Hello,
I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
Other Trending Topics
I am happy to introduce the very α version of the new programming language compiled to BEAM.
Welcome Cure.
It has literally three kille...
New
Hi there! We created Gust: A task orchestrator inspired by Airflow.
For those who have never heard about Aiflow, it’s a Python-based wor...
New
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve.
They are GUI (Emerge) and State management (S...
New
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #library
- #deployment
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #discussion
- #code-sync
- #podcasts
- #javascript
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixirconf-us
- #blog-post
- #ai
- #elixir-ls
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #hex
- #security
- #metaprogramming










Showing Posts 1 to 1- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
michallepicki
insert_onedoes not contain{:error, %Mongo.WriteError{}}in the return type. Whether theirresulttype should be updated or not, I’m not sure. Notice that I wrote{:error, %Mongo.WriteError{}}and not{:error, Mongo.WriteError.t()}- I checked and there is no@type tdefined in that module so it does not mean anything. This module got introduced in this commit and specs were not updated.@dialyzermodule attribute. If you usedialyxir, their README.md lists a few more ways to ignore warnings. To me, the ignore file with string matches seems to be the most commonly used way to do that.-Woverspecsoption. It is opt-in because it can introduce a lot of noise. Dialyzer has its limits and does not know how to deal with very complex types so it may sometimes “round up” some types to more general ones. I think Elixir’swithmay be sometimes confusing it as well? I’m not sure. Adding specs to private functions used may help it. But overall, Dialyzer doesn’t guarantee to find all problems in your code.