Qqwy

Qqwy

TypeCheck Core Team

Using Plug.Upload in your changesets

Hello Everyone,

I am working on a small Phoenix/Ecto project. One of the features of this application is going to be that people can upload images. Right now I am using arc (and arc_ecto) to make the uploading procedure easier.

However, I want to store the dimensions and other metadata of the image that has been saved in the database as well, to make it nicer to display it in a gallery later.
I know there are multiple packages on Hex.pm that allow you to do this, such as fastimage, but these libraries work with a pathname to the file.

  • Exactly how can I make a library that takes a pathname consume a %Plug.Upload{} struct? I believe it contains a :path field, but I have been unable to build a %Plug.Upload{} manually to try it out. There is documentation of Plug.Upload, but it is rather short and uninformative (does the :path field include or exclude the actual filename itself, or only its folder? How do you make a %Plug.Upload{} struct manually?).
  • Related to this: How can you test file-uploading code? I am interested in doing both a feature-test, testing only if when you have a file if the dimensions are read and added to the changeset properly, and a full-stack test where a file is selected from the browser and it is then attempted to be uploaded.

Any help is greatly appreciated!

Most Liked

josevalim

josevalim

Creator of Elixir

When you do it as post(conn, table_upload_path(conn, :create, table_upload: params)), you are passing the parameters as part of the query string, i.e. as part of the URL. You need to pass it as part of the post:

conn = post(conn, table_upload_path(conn, :create), table_upload: params)
arkgil

arkgil

IIRC, when I was working with file uploads in tests, I was creating Plug.Upload struct manually and passed it as regular parameter to get, post etc. macros in controller tests:

post conn, image_path(conn, :create), upload: %Plug.Upload{...}

EDIT: but of course the question is about changesets :blush: I think @OvermindDL1 is with the right approach.

Qqwy

Qqwy

TypeCheck Core Team

All right! I have since learned that the :path field is a path to a temporary file (including the filename itself). The :filename is the name used during uploading, which can be used to do (a weak form of!) MIME-checking, and possibly to store it in your app, etc.

I was able to call ImageMagick using the extracted :path. (Yes, this code should be cleaned up and get some documentation, but it’s a proof-of-concept.)

defmodule Cmd.Magick do
  def dimensions(file_path) do
    case System.cmd("identify", ["-format","%w %h", Path.expand(file_path)]) do
      {res, 0} ->
        [width, height] =
          res
          |> String.split
          |> Enum.map(&String.to_integer/1)
        %{width: width, height: height}
      {_other, _} ->
        raise ArgumentError
    end
  end
end

In my Phoenix 1.3 changeset function I’ve added a call to this function to the pipeline:

  def add_image_dimensions(changeset, attrs) do
    case attrs["image"] do
      %Plug.Upload{path: path, filename: filename} ->
        changeset
        |> cast(Cmd.Magick.dimensions(path), [:width, :height])
      path when is_binary(path) ->
        changeset
        |> cast(Cmd.Magick.dimensions(path), [:width, :height])
      _ ->
        changeset
    end
  end

This works!

What I am yet to figure out though, is how this code can be tested properly. Please help!

Where Next?

Popular in Questions Top

earth10
Hi, I’m just starting to build a side-project with Elixir and Phoenix and doing some basic test with Elixir alone. What strikes me is th...
New
shahryarjb
Hello, I have map which I want to convert it to string like this: the map: %{last_name: "tavakkoli", name: "shahryar"} the string I ne...
New
jononomo
I am trying to figure out how Mix knows whether the environment is test, dev, or prod -- where is this set? Thanks.
New
minhajuddin
I have seen a lot of code which picks the first element from a list using Enum.at(0) instead of List.first. Is there a reason why people ...
New
RisingFromAshes
I've read in another post that it may be possible with a router helper - but I couldn't find an appropriate one, and tbh, I'm still just ...
New
Lily
In templates/appointment/index.html.eex: <%= for appointment <- @appointments do %> <tr> <td><%= appoi...
New
fayddelight
I tried installing elixir 1.11.2 erlang 23.3.4 via asdf in my zsh shell. Enabled the versions locally and globally. When I list them ...
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New
senggen
Erlang/OTP 25 [erts-13.2.2] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] 15:22:35.803 [error] gen_event {lager_file_backend...
New
lanycrost
Hi everyone! I need implement if…else if…else condition from my elixir code, and anymore of this control flow structures not work proper...
New

Other popular topics Top

marius95
Hello everyone, I try to use an Javascript Event Handler in my root.html.leex file. Therefore I created a function in the app.js file: ...
New
lastday4you
I wanted to check elixir version in phoenix because i found that my elixir is 1.5 but when i use Enum.chunk_by it said the function is un...
New
mcarvalho
What is the difference between System.get_env and Application.get_env? For example, what are best practices to use one versus another.
New
chrismccord
As promised, the first release candidate of Phoenix 1.3.0 is out! This release focuses on code generators with improved project structure...
New
JorisKok
I have a server on AWS, and was running a load test using artillery. When looking at the Phoenix dashboard I see the Ports going to 100% ...
New
dokuzbir
I want to highlight html closing tags when i click a html tag. That works in .html files but doesnt work for html.eex templates. How can...
New
Qqwy
Original source of discussion: This topic on the Pragmatic Programmers' Functional Web Development with Elixir, OTP, and Phoenix forum. ...
New
ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
AstonJ
Seen any cool LiveView demos, sample apps or examples? Please post them here! :003:
New
lanycrost
Hi everyone! I need implement if…else if…else condition from my elixir code, and anymore of this control flow structures not work proper...
New

We're in Beta

About us Mission Statement