markdev
Using result of intermediate insert in transaction with Ecto Multi
Using Ecto v2.2.6, Phoenix 1.3
I have a blog app. When a user makes a Post, it inserts into the Post table, then it get the resulting id of that post and inserts that into a Newsfeeditem table. Ideally, I would like for this to happen as a transaction.
(I am using Absinthe graphql, so my return for the insert must be of the form {:ok, post})
I have a working function that looks like this:
def create_post_add_newsfeed(%{
title: title,
content: content,
user_id: user_id
}) do
case Repo.insert!(%Post{title: title, content: content, user_id: user_id}) do
post ->
case Repo.insert!(%Newsfeeditem{type: "user_creates_post", user_id: user_id, post_id: post.id}) do
newsfeeditem ->
{:ok, post}
_ ->
{:error, "Post not recorded in newsfeed"}
end
_ ->
{:error, "Post not inserted"}
end
end
This code is not a transaction, and it reeks of callback stink. Ecto.Multi seems like a more appropriate tool to use here, but I do not know how to get the result of the Post insert so that I can insert it into Newsfeed.
I would like to do something like this
def create_post_add_newsfeed(%{
title: title,
content: content,
user_id: user_id
}) do
multi =
Multi.new
|> Multi.insert(:post, %Post{title: title, content: content, user_id: user_id})
|> # Some intermediate step where I get the 'post' from the line above
|> Multi.insert(:newsfeeditem, %Newsfeeditem{type: "user_creates_post", user_id: users_id, post_id: post.id})
case Repo.transaction(multi) do
{:ok, %{post: post}} ->
{:ok, post}
{:error, _} ->
{:error, "Error"}
end
end
Any idea how to pull that off?
Marked As Solved
cmkarlsson
Yes, the Repo.update will update the database outside the transaction. The Multi.update/4 takes a changeset.
You could create a new function:
def post_changeset(%Post{} = post, attrs) do
post
|> Post.changeset(attrs)
and use this in the Multi transaction.
Multi.new
|> Multi.update(:post, post_changeset(post, %{content: "Content"})
|> Multi.insert(...)
...
NOTE: Has not been tested ![]()
Also Liked
cmkarlsson
Have a look at Ecto.Multi — Ecto v3.14.0
This function receives the result of the previous Multi step as an argument. In this case you’d return the inserted Post from the step and intercept it.
The “whats-new-in-ecto-2.0.1” ebook contains a section doing just this (Composable transactions with Ecto.Multi) (http://pages.plataformatec.com.br/ebook-whats-new-in-ecto-2-0)
SZJX
In my case I needed to follow the initial insertion with an insert_all operation. Multi.merge helped.
cmkarlsson
What does update_post function do? Is it possible that this one updates the database outside of the multi transaction? If so that would explain what you are seeing.
Popular in Questions
Other popular topics
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #websockets
- #supervisor
- #advent-of-code
- #elixirconf-us
- #distillery
- #processes
- #forms
- #api
- #metaprogramming
- #security
- #performance








