markdev

markdev

Using Ecto v2.2.6, Phoenix 1.3

I have a blog app. When a user makes a Post, it inserts into the Post table, then it get the resulting id of that post and inserts that into a Newsfeeditem table. Ideally, I would like for this to happen as a transaction.

(I am using Absinthe graphql, so my return for the insert must be of the form {:ok, post})

I have a working function that looks like this:

  def create_post_add_newsfeed(%{
      title: title,
      content: content,
      user_id: user_id
    }) do

    case Repo.insert!(%Post{title: title, content: content, user_id: user_id}) do
      post ->
        case Repo.insert!(%Newsfeeditem{type: "user_creates_post", user_id: user_id, post_id: post.id}) do
          newsfeeditem ->
            {:ok, post}
          _ ->
            {:error, "Post not recorded in newsfeed"}
        end
      _ ->
      {:error, "Post not inserted"}
    end
  end

This code is not a transaction, and it reeks of callback stink. Ecto.Multi seems like a more appropriate tool to use here, but I do not know how to get the result of the Post insert so that I can insert it into Newsfeed.

I would like to do something like this

  def create_post_add_newsfeed(%{
      title: title,
      content: content,
      user_id: user_id
    }) do
    multi =
      Multi.new
        |> Multi.insert(:post, %Post{title: title, content: content, user_id: user_id})
        |> # Some intermediate step where I get the 'post' from the line above
        |> Multi.insert(:newsfeeditem, %Newsfeeditem{type: "user_creates_post", user_id: users_id, post_id: post.id})

    case Repo.transaction(multi) do
      {:ok, %{post: post}} ->
        {:ok, post}
      {:error, _} ->
        {:error, "Error"}
    end
  end

Any idea how to pull that off?

Showing Posts 1 to 7

cmkarlsson

cmkarlsson

Have a look at Ecto.Multi — Ecto v3.14.0

This function receives the result of the previous Multi step as an argument. In this case you’d return the inserted Post from the step and intercept it.

The “whats-new-in-ecto-2.0.1” ebook contains a section doing just this (Composable transactions with Ecto.Multi) (http://pages.plataformatec.com.br/ebook-whats-new-in-ecto-2-0)

markdev

markdev OP

@cmkarlsson Thanks, that worked great!

I’ve run into a new issue with Multi.update. When I update a Post’s content, it also adds a Newsfeed entry.

Here is the wrapper function:

  def updateContent(%{id: id, content: content}, _info) do
    post = Repo.get(post, id)
    Content.update_content_and_add_to_newsfeed(post, %{id: id, content: content})
  end

And here is the logic in the Content context:

  def update_content_and_add_to_newsfeed(post, %{id: id, content: content}) do
    multi =
      Multi.new
        |> Multi.update(:post, update_post(post, %{content: content}))
        |> Multi.insert(:newsfeed, %Newsfeed{message: "post updated"})

    case Repo.transaction(multi) do
      {:ok, %{post: post}} ->
        {:ok, post}
      {:error, _} ->
        {:error, "Error"}
    end
  end

When I run this code, the content updates in the database, but no newsfeed item gets inserted, and I see this error message in the console:

Server: localhost:4000 (http)
Request: POST /graphiql
** (exit) an exception was raised:
    ** (FunctionClauseError) no function clause matching in Ecto.Multi.update/4

Any idea how to fix this?

cmkarlsson

cmkarlsson

What does update_post function do? Is it possible that this one updates the database outside of the multi transaction? If so that would explain what you are seeing.

markdev

markdev OP

Here it is:

  def update_post(%Post{} = post, attrs) do
    post
    |> Post.changeset(attrs)
    |> Repo.update()
  end
cmkarlsson

cmkarlsson

Yes, the Repo.update will update the database outside the transaction. The Multi.update/4 takes a changeset.

You could create a new function:

def post_changeset(%Post{} = post, attrs) do
    post
    |> Post.changeset(attrs)

and use this in the Multi transaction.

Multi.new
|> Multi.update(:post, post_changeset(post, %{content: "Content"})
|> Multi.insert(...)
...

NOTE: Has not been tested :slight_smile:

markdev

markdev OP

Got it. This is what worked:

|> Multi.update(:post, Post.changeset(post, %{content: content}))
SZJX

SZJX

In my case I needed to follow the initial insertion with an insert_all operation. Multi.merge helped.

— All posts loaded —

Where Next? Top

Trending in Questions Top

katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
achenet
Hello, I’m trying to build a basic Phoenix web-app, and I’d like to use Tailwind. However, when I launch mix phx.server, I get an error...
New
bradley
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
unaware8150
Hello folks! So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
Cxx-mlr
I’m working on a small exercise involving update_in/3, and I came up with this solution: data = %{ name: "Periodic Table", category:...
New
Alvinkariuki
How Can I Optimise Compile Time Dependencies I have been building an elixir application for about 2 years now. Many modules and files ha...
New

Other Trending Topics Top

GenericJam
Edit: 2026 May 15 - This post is archived. Mob is alive!! Main docs: mob v0.7.11 — Documentation A bit of explanation for the slightly c...
New
budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews