LukasKnuth

LukasKnuth

In my config/runtime.exs I have the following:

timezone = System.get_env("TZ") || "Etc/UTC"

unless Timex.is_valid_timezone?(timezone) do
  raise """
  The timezone specified in the TZ environment variable is invalid.
  """
end

config :my_app, MyApp, timezone: timezone

My intention is that a valid Timezone will work as expected while an invalid one (such as Europe/Börlin) crashes the application early.In the rest of the App, I can then assume that the user-supplied timezone is always valid.

This works as expected in dev, on prod however, this results in a crash at runtime:

ERROR! Config provider Config.Reader failed with:
** (ArgumentError) errors were found at the given arguments:
  * 1st argument: the table identifier does not refer to an existing ETS table
    (stdlib 6.2) :ets.lookup(:tzdata_current_release, :release_version)
    (tzdata 1.1.3) lib/tzdata/release_reader.ex:74: Tzdata.ReleaseReader.current_release
    (tzdata 1.1.3) lib/tzdata/release_reader.ex:17: Tzdata.ReleaseReader.simple_lookup/1
    (tzdata 1.1.3) lib/tzdata/release_reader.ex:9: Tzdata.ReleaseReader.zone_and_link_li
    (tzdata 1.1.3) lib/tzdata.ex:61: Tzdata.zone_exists?/1
    (timex 3.7.13) lib/timezone/timezone.ex:230: Timex.Timezone.name_of/1
    (timex 3.7.13) lib/timex.ex:857: Timex.is_valid_timezone?/1
    /app/releases/0.1.0/runtime.exs:13: (file)

I’m assuming this happens because the Timex application isn’t started yet when the runtime configuration is evaluated.

So instead, I now have this workaround that achieves the same thing:

defmodule MyApp.Application do
  use Application

  @impl true
  def start(_type, _args) do
    with :ok <- validate_timezone_config() do
      # shortened
      Supervisor.start_link(children, opts)
    end
  end

  defp validate_timezone_config do
    timezone = Briefly.user_timezone()

    case Timex.is_valid_timezone?(timezone) do
      true -> :ok
      false -> {:error, "Configured timezone '#{timezone}' is invalid"}
    end
  end
end

If an invalid timezone is supplied, the app crashes early:

11:39:02.487 [notice] Application briefly exited: Briefly.Application.start(:normal, []) returned an error: "Configured timezone 'Europe/Börlin' is invalid"
** (exit) :terminating
    (kernel 10.2.1) application_controller.erl:511: :application_controller.call/2
    (kernel 10.2.1) application.erl:367: :application."-ensure_all_started/3-lc$^0/1-0-"/1
    (kernel 10.2.1) application.erl:367: :application.ensure_all_started/3
    (mix 1.18.2) lib/mix/tasks/app.start.ex:72: Mix.Tasks.App.Start.start/3
    (mix 1.18.2) lib/mix/task.ex:495: anonymous fn/3 in Mix.Task.run_task/5
    (mix 1.18.2) lib/mix/tasks/run.ex:129: Mix.Tasks.Run.run/5
    (mix 1.18.2) lib/mix/tasks/run.ex:85: Mix.Tasks.Run.run/1
    (mix 1.18.2) lib/mix/task.ex:495: anonymous fn/3 in Mix.Task.run_task/5

Is this considered an anti-pattern? Is there a more appropriate/easier way to validate runtime configuration during startup?

Showing Posts 1 to 1

LostKobrakai

LostKobrakai

You should be able to do Application.ensure_all_started in the runtime config, but that would also mean you cannot configure the started application and its dependencies anymore in runtime.exs. Validating in the application start callback is free of that chicken-egg type problem of what runs first.

— All posts loaded —

Where Next? Top

Trending in Questions Top

water
I’m aware of 2 such projects, are there others? git: GitHub - team-alembic/realworld: A fullstack Phoenix LiveView application with back...
New
katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
bradley
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
unaware8150
Hello folks! So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
Alvinkariuki
How Can I Optimise Compile Time Dependencies I have been building an elixir application for about 2 years now. Many modules and files ha...
New

Other Trending Topics Top

budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
budgie
I love Elixir. It’s one of 2 programming languages I’ve ever fallen in love with. But I don’t use it anymore. Serverless was the promis...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews