mbuhot
Is there a convention/idiom for defining structs that require validation on construction?
I notice the standard library types Date and Time define a new function that returns an error tuple when the inputs are invalid:
iex> Date.new(0,0,0)
{:error, :invalid_date}
Is there any downside to declaring structs as ecto embedded_schema with a new/1 function that returns an error tuple? eg:
defmodule MyStruct do
use Ecto.Schema
alias Ecto.Changeset
@primary_key false
embedded_schema do
field :a, :integer
field :b, :string
end
def new(attrs) do
case cs = changeset(%MyStruct{}, attrs) do
%{valid?: true} -> {:ok, Changeset.apply_changes(cs)}
_ -> {:error, changeset_errors(cs)}
end
end
defp changeset(data = %MyStruct{}, attrs) do
data
|> Changeset.cast(attrs, [:a, :b])
|> Changset.validate_required([:a, :b])
|> Changeset.validate_format(:b, ~r/@/)
end
defp changeset_errors(changeset) do
Changeset.traverse_errors(changeset, fn {msg, opts} ->
Enum.reduce(opts, msg, fn {key, value}, acc ->
String.replace(acc, "%{#{key}}", to_string(value))
end)
end)
end
end
Trending in Questions
Hello everyone!
I am new to coding with Elixir/Erlang. And i am looking for some utilities for fuzzing testing like AFL++.
Does anyone ...
New
I’m very new to Elixir, so sorry if this is a silly question:
I am wondering what happens to the mailbox of a process when the machine i...
New
How do I tell Hologram not to escape HTML when substituting into templates?
{Textile.render(@product.long_description)}
escapes the HTM...
New
I load tested a plain Phoenix chat app backed by Postgres with 100 million messages in it, everything on default settings, to see what br...
New
Background
When trying to execute mix release on a Windows 11 machine for a Phoenix project I get the following error:
* assembling mark...
New
I’d like to create a file with 600 permissions (rw-------), but there’s a race condition if I create it and then change the permissions. ...
New
Is there a way to import record definitions in the iex shell for pretty printing (similar to the rr command in the erl shell)? This woul...
New
Other Trending Topics
Edit: 2026 May 15 - This post is archived.
Mob is alive!!
Main docs: mob v0.7.11 — Documentation
A bit of explanation for the slightly c...
New
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
(I just needed to vent somewhere and LinkedIn is full of hope, or hype, I’m not sure which exactly)
AI dream has many faces, but general...
New
Localize is the next generation localisation library for Elixir. Think of it as ex_cldr version 3.0. The first version will be released ...
New
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #library
- #deployment
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #code-sync
- #discussion
- #podcasts
- #javascript
- #onsite
- #dialyzer
- #docker
- #authentication
- #ai
- #elixirconf-us
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #blog-post
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #elixirconf-eu
- #security
- #processes
- #api
- #forms
- #hex










Showing Posts 1 to 5- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
Qqwy
Indeed, using a
newfunction, combined with declaring the struct’s type as@opaque(as hint that people should not construct it directly and in many cases not pattern match on it directly either) is the convention that is used for this. As for the return value in case of an error, there is no convention for this, (I have seen all of%MyStruct{} | nil,%MyStruct{} | {:error, reason}and{:ok, %MyStruct{}} | {:error, reason}; I like the third the most myself, but it depends on the situation).As for the example with the Ecto changeset: I am not sure this is the proper way. It feels like you are partially re-inventing the logic that changesets themselves provide, but I am not immediately sure how to improve on it.
It feels more natural to me to have
MyStruct.new()return a version of the struct with sensible default values (without any filled in ‘attrs’) and explicitly fill in the changeset withattrsat the place where you use it, i.e:mbuhot
Thanks @Qqwy !
I’m not so much concerned with structs that will be used with a
Repo, as%Changeset{}or%Multi{}works really well in those cases.But for cases where you might otherwise use
defstruct, isembedded_schemaa suitable alternative, for the convenience ofChangeset.castandChangeset.validate_*functions?ashneyderman
you can use straight maps with Changeset. If you need to validate you can always validate a map and create struct from the map afterwards.
mbuhot
Thats neat!
However I like the idea of making structs composable with
embeds_one/embeds_manywhich I don’t think is supported with schemaless changesets?ashneyderman
I use validate_change for the embedded maps, which takes function as validator. This way you can compose validations pretty much for any imaginable structure.