Web and Lib

ngw · September 9, 2016, 3:56pm

Hello *. I know the difference between web/ and lib/ in Phoenix, but still I have some doubts about where to put some things
I have a module whose task is to query and external HTTP server and encode/decode JSON, nothing fancy.
I’ve put it under web/models, but honestly my gut feeling is that it’s not supposed to be there.

gist.github.com

https://gist.github.com/ngw/fd037084af03f75cdf7540117551a8f1

external_service.ex

defmodule Owl.MacawService do
  @derive [Poison.Encoder]
  defstruct [:id,
             :name,
             :code,
             :notification_endpoint,
             :legacy_notifications,
             :created_at,
             :updated_at]

This file has been truncated. show original

The choice to put it under models/ was because at the beginning it was used mostly by controllers directly, but now it’s called from my toniq workers, and it doesn’t feel “natural” anymore.
Should I move it under lib? Where would you put it?

TIA,
ngw

sztosz · September 9, 2016, 7:50pm

I think you can even move it totally different app I would probably put in to the lib in Services directory/module if it’s small, and into a new app if it was bigger than small.