kyde

kyde

Which approach is better having multiple `handle_call` callbacks when using `GenServer` behavior or using helper functions?

I have a module where am using GenServer. In this module the state is a list of items. The module exposes functions to filter these items according to various criteria.
My question is what is the best approach to solving this task. Would it be better to:

  1. Add multiple handle_call callbacks for each filter criterion.
  2. Use the list_items functions and then filter its return value using multiple helper functions instead of the multiple handle_call callbacks.

Here is a simple implementation of the first approach:

defmodule Repositories do
  use GenServer
  
 ## API
  def start_link(_opts) do
    .GenServer.start_link(__MODULE__, :ok)
  end

  def list_items(pid) do
    GenServer.call(pid, :list_items)
  end

  def filter_by_name(pid, repo_name) do
   GenServer.call(pid, {:filter_by_name, repo_name})
  end
  
  # Other APIs here for filtering by other criteria
   ....

  ## Server
  def init(:ok) do
    initial_repos = #Fetch initial repos.
    {:ok, initial_repos}
  end

 def handle_call({:filter_by_name, repo_name}, _from, state) do
   matching_repos = Enum.filter(state, fn repo -> String.equivalent?(repo.name, repo_name) end)

   {:reply, matching_repos, state}
 end

  def handle_call(:list_items, _from, state) do
    {:reply, state, state}
  end

  # Other callbacks here for handling calls to filter by the other various criteria
   ....
end

Here is a simple implementation of the second approach:

defmodule Repositories do
  use GenServer
  
 ## API
  def start_link(_opts) do
    .GenServer.start_link(__MODULE__, :ok)
  end

  def list_items(pid) do
    GenServer.call(pid, :list_items)
  end

  def filter_by_name(pid, repo_name) do
   pid
   |> list_items()
   |> Enum.filter(fn repo -> has_name?(repo.name, repo_name) end)
  end
  
  # Other APIs here for filtering by other criteria
   ....

  ## Server
  def init(:ok) do
    initial_repos = #Fetch initial repos.
    {:ok, initial_repos}
  end

  def handle_call(:list_items, _from, state) do
    {:reply, state, state}
  end

  ## Helper functions
  def has_name?(actual_name, repo_name) do
    String.equivalent?(actual_name, repo_name)
  end
  # Other  helper functions to perform filtering by other criteria
   ....
end

Which approach is more favored in the elixir community?

Most Liked

al2o3cr

al2o3cr

The data structure you return from handle_call is copied back to the calling process. If state is large, this will make the second approach significantly more expensive to execute.

A third approach worth considering: have one handle_call that accepts a filter function:

def filter_by_name(pid, repo_name) do
  list_items(pid, fn repo -> has_name?(repo.name, repo_name) end)
end

def list_items(pid, filter \\ fn x -> x end) do
  GenServer.call(pid, {:list_items, filter})
end

def handle_call({:list_items, filter}, from, state) do
  {:reply, Enum.filter(state, filter), state}
end

This avoids copying state to the calling process by instead bringing filter to the data.

Where Next?

Popular in Questions Top

marius95
Hello everyone, I try to use an Javascript Event Handler in my root.html.leex file. Therefore I created a function in the app.js file: ...
New
sen
Hi All, I set a environment variables in dev.exs , like below code. when i start server, how can i set the ${enable} value? thanks. d...
New
stefanchrobot
What’s the safe way to decode a JSON string into a struct? I want to avoid calling String.to_atom. Jason.decode can give me a map with st...
New
jaysoifer
Is there a way to rollback a specific migration and only that one (“skipping” all the other ones)? Would mix ecto.rollback -v 200809061...
New
beno
I will often find my self writing things similar to: case some_value do nil -> something() "" -> something() _ -> somethi...
New
alice
Hey, Just curious what are the main benefits of Elixir compared to Clojure? When is Elixir more useful than Clojure and vice versa? Th...
New
Lily
In templates/appointment/index.html.eex: <%= for appointment <- @appointments do %> <tr> <td><%= appoi...
New
script
If I have a string “1000 cfu/ml” . I want to remove the characters and / and space . So the string is like this "1000" What is the ...
New
vegabook
I’m brand new to Phoenix and I have stripped one of the demo applications to the bone. I just want to get an svg up on the screen. Here i...
New
chensan
I have a User schema with a :from_id field set to type :string: defmodule TweetBot.Repo.Migrations.CreateUsers do use Ecto.Migration ...
New

Other popular topics Top

marius95
Hello everyone, I try to use an Javascript Event Handler in my root.html.leex file. Therefore I created a function in the app.js file: ...
New
vertexbuffer
Hello, can anybody help here..? I have a list of players and I what to delete an element, but every for loop the list is reverting to ori...
New
gshaw
What is the idiomatic way of matching for not nil in Elixir? E.g., First way: defp halt_if_not_signed_in(conn, signed_in_account) when...
New
Qqwy
Original source of discussion: This topic on the Pragmatic Programmers’ Functional Web Development with Elixir, OTP, and Phoenix forum. ...
New
ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
AstonJ
Please see the new poll here: Which code editor or IDE do you use? (Poll) (2022 Edition) It’s been a while since we first asked this, I...
208 31142 143
New
komlanvi
Hi everyone, I was playing with phoenix liveView but I run into an issue. I have a form and want to validate each input text when the te...
New
WestKeys
Currently suffering from paralysis by [HTTP client] analysis. This is rather unusual in Elixirland as there tends to be consensus on the ...
New
sergio
Kind of like when jquery came out, it was super necessary. Existing drag and drop libraries have a bunch of baggage to support old browse...
New
vonH
In asking this question I am more interested about the expressiveness of the language itself and less concerned about the availability of...
New

We're in Beta

About us Mission Statement