Why aren't all test suites generated by mix phx.gen.auth tagged with `async: true`?

Phoenix Forum Questions / Help
, ,
1

I’m looking at the code for mix phx.gen.auth and I’ve seen that only part of the test files generated use async: true. For example, ConfirmationControllerTest uses async: true if the Ecto adapter is set to Postgres but the SettingsLiveTest suite does not use async. Why is this the case?

In a simple demo app, I’ve ran this Mix Task and tagged all of the test suites with async: true and even after hundreds of runs, I see no failures. I assume there’s some reason these specific suites are not marked to be run asynchronously so I’d like to understand.

Thanks :smiley:

2 Likes
2

Welcome to the forums :slight_smile:

I don’t have a definitive answer for you, but investigating it myself I can see that file was introduced in this PR - https://github.com/phoenixframework/phoenix/pull/4872

And that line hasn’t been changed since. I wouldn’t be surprised if this was simply an omission. You could PR a fix and get some more direct feedback that way.

1 Like
3

Please send a PR to make all of them async: true and ping me. :slight_smile:

4 Likes