Why does Logger.Translator ignore gen_statem reports?

al2o3cr · February 8, 2021, 6:55pm

There is code in Logger.Translator to turn termination reports from gen_server and gen_event into formatted messages with crash_report metadata.

github.com

elixir-lang/elixir/blob/d30c5c0185607f08797441ab8af12636ad8dbd7e/lib/logger/lib/logger/translator.ex#L39-L50


def translate(min_level, _level, :report, {:logger, %{label: label} = report}) do
  case label do
    {:gen_server, :terminate} ->
      report_gen_server_terminate(min_level, report)
    {:gen_event, :terminate} ->
      report_gen_event_terminate(min_level, report)
    _ ->
      :skip
  end
end

Since gen_statem is also part of the BEAM stdlib, should its messages be transformed similarly? They don’t have quite the same format as the ones from gen_server.

The GenStateMachine library includes a translator, but it has not been updated to match the new behavior of Logger.Translator.

josevalim · July 13, 2021, 9:41am

Yes, please consider updating the GenStateMachine library. For Elixir we will focus on the behaviours that are part of/used by Elixir.