silverdr

silverdr

While the same approach (i. e.) with view module as argument in Phoenix.View is not? Yes, I know it has been documented as being deprecated good time ago. I am asking about the reason for doing it in the first place and creating such difference/inconsistency on the way.

Showing Posts 1 to 2

al2o3cr

al2o3cr

The issue where the deprecation message was introduced has some discussion:

https://github.com/phoenixframework/phoenix/issues/2469#issuecomment-440340830

silverdr

silverdr OP

Thanks for the link. There’s:

I think our clauses were laid out in a way where you could pass a template where a view was expected or vice-versa because we were matching on the type and that can be a security issue if people are not careful. I mean, people would have to already be doing something wrong, but better to be safer and keep the API simple.

which (I think) tries to give an answer to the question, although I am afraid I don’t understand it properly enough to find it cogent. Not that it’s a major issue or so. Just, unless there’s an important reason for it, it feels like another tiny bit of unnecessary friction. It might only be me, but I tend to also value consistency, not only simplicity :wink: And potential security aspects could most probably be addressed without API changes.

Anyway, reworked all my calls to “render/4 with a view” in controllers into two calls in order to silence the deprecation warnings, and noted mentally down “no, no, in controllers you’re not supposed to do the same as in views!” :wink:

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews