kelvinst

kelvinst

Why is defmodule line marked as executable on mix test --cover?

When I run mix test --cover in my Phoenix project, I get some files with poor coverage because they are tiny modules with a use Something, and some of them mark the defmodule X do line as executable.

e.g.

Any idea why?

Marked As Solved

sodapopcan

sodapopcan

This really piqued my curiosity so I put together a little test and it seems you’re… half right? I’m not exactly known for being able to come up with the most accurate scenarios for these things but it appears you just need to use something from the dependency module.

With this test:

defmodule CoverTest do
  use ExUnit.Case

  test "foobars the world" do
    assert Cover.hello() == "foobar"
  end
end

…and this dependency module:

defmodule Cover.Dep do
  defmacro __using__(_) do
    quote do
      def foo, do: "foo"
      def bar, do: "bar"
    end
  end
end

…this gets 50% coverage:

defmodule Cover do
  use Cover.Dep

  def hello do
    "foobar"
  end
end

…and this gets 100%:

defmodule Cover do
  use Cover.Dep

  def hello do
    foo() <> bar()
  end
end

…which I thought proved your theory right until I tried this:

defmodule Cover do
  use Cover.Dep

  def hello do
    foo() <> "bar"
  end
end

…which also scores 100% :face_with_spiral_eyes:

So ya, I know your post is only 5 hours old but BUMP for anyone who knows! :slight_smile:

EDIT: Oh, perhaps it’s because it doesn’t consider strings executable so the fact that you are using anything from the module means it’s covered?

Also Liked

christhekeele

christhekeele

I’m only 98.33% guilty of this, but otherwise agree!

kelvinst

kelvinst

It scores 100% because as foo and bar are defined by Cover.Dep, using any function defined from it would mark the defmodule line as covered. The defs inside quotes aren’t marked as executable by the coverage tool at all.

Anyway, thanks for the investigation! That’s definitely why I posted here, cause I knew there was going to be someone as curious as I am - but not as lazy as I was - that would test it :smile:

sodapopcan

sodapopcan

I feel so used :sweat_smile:

Right, that makes sense, thanks!

Last Post!

christhekeele

christhekeele

I’m only 98.33% guilty of this, but otherwise agree!

Where Next?

Popular in Questions Top

nobody
Hi! In PHP: $_SERVER[‘SERVER_ADDR’] - in Elixir? Searched the docs for ip address and the web, no good results. Thanks!
New
JeremM34
Hello, how can I check the Phoenix version ? Thanks !
New
lessless
I believe there are people here who are dealing with CSV files import on the daily basis, and since Excel is a really popular tool there ...
New
Darmani72
If I have a post route which an argument: post /my_post_route/:my_param1, MyController.my_post_handler How would get the post params ...
New
gshaw
What is the idiomatic way of matching for not nil in Elixir? E.g., First way: defp halt_if_not_signed_in(conn, signed_in_account) when...
New
albydarned
Hello all! I am typing this post from my new MacBook Pro with the M1 chip. I’m loving it so far, and will probably use it as my daily dr...
New
Harrisonl
We have an ECS cluster with 4 services, where each task joins a single cluster, via discovery ECS discovery service. Currently when I de...
New

Other popular topics Top

JakeBecker
TL;DR: I’ve just released an implementation of Microsoft’s IDE-independent Language Server Protocol for Elixir. It adds language support ...
1144 54921 245
New
lanycrost
Hi everyone! I need implement if…else if…else condition from my elixir code, and anymore of this control flow structures not work proper...
New
axelson
This post is a wiki (feel free to hit the edit button near the bottom right of this post to add your own changes!) This post collects co...
239 49084 226
New
Patoshizzle
After calling mix ecto.create I get this error: 17:00:32.162 [error] GenServer #PID&lt;0.412.0&gt; terminating ** (Postgrex.Error) FATAL...
New
jason.o
In the code below, if the create action is not set to accept “extra_key” as an input, it errors out with a message shown above. Is there ...
New
AstonJ
Posting this to see if we can make things easier for people to get into Neovim. If you use Neovim and have a favourite distro please let ...
New

We're in Beta

About us Mission Statement