Papillon6814

Papillon6814

Hello.
I’m reading elixir-lang/elixir for my study. I found a strange point in ExUnit.
That’s this.

defmacro assert({:=, meta, [left, right]} = assertion) do
    code = escape_quoted(:assert, meta, assertion)

    # If the match works, we need to check if the value
    # is not nil nor false. We need to rewrite the if
    # to avoid silly warnings though.
    check =
      suppress_warning(
        quote do
          case right do
            x when x in [nil, false] ->
              raise ExUnit.AssertionError,
                expr: expr,
                message: "Expected truthy, got #{inspect(right)}"

            _ ->
              :ok
          end
        end
      )

    __match__(left, right, code, check, __CALLER__)
  end

I think the right variable should be unquoted.

defmacro my_if(condition, clauses) do
    do_clause = Keyword.get(clauses, :do, nil)
    else_clause = Keyword.get(clauses, :else, nil)
    
    quote do
      case unquote(condition) do
        x when x in [false, nil] ->
          unquote(else_clause)
        _ ->
          unquote(do_clause)
      end
    end
  end

This is my_if function which is written in a book. I don’t know why both my_if and the assert work.

Showing Posts 1 to 7

Aetherus

Aetherus

This clause of assert handles the pattern matching case like

assert foo = bar

where foo is a pattern and bar can be anything.

Remember that atoms keep as is in the code and in the AST, and false and nil are atoms. So, if right is literally nil or false in the code, it is nil or false in the AST, too. And if right is nil or false, the assertion will definitely fail because pattern matching using = always returns the right hand side if it matches the left hand side, or raises an error if it does not match. So, in this specific case, unquote(right) should not be used.

The other cases of pattern matching when right is not literally false or nil is handled by the line

__match__(left, right, code, check, __CALLER__)
Papillon6814

Papillon6814 OP

Thank you for your answer!

Sorry, I’m not sure why it should not be unquoted…
I think variables in quote should occurs an error without being unquoted.

But right in above code is not unquoted. Why it does not occur any errors?

Aetherus

Aetherus

Sorry, It was my misunderstanding of the code in ExUnit.

I stared at the code closely, and saw this:

def __match__(left, right, code, check, caller) do
  ...
  match_expr = ... # It's an AST!!
  
  quote do
    right = unquote(right)  #<---- This line does the trick!
    expr = unquote(code)
    unquote(vars) = unquote(match_expr)
    right
  end
end
Aetherus

Aetherus

By the way, it’s totally OK to access an undeclared variable inside quote, for example, in a brand new IEx session,

iex> quote do: foo
{:foo, [], Elixir}

It does not raise error.

Papillon6814

Papillon6814 OP

Wow that’s true!

I don’t understand why assert function works with the __match__ function… Would you explain why? :sob: :sob:

kip

kip

ex_cldr Core Team

When you try to perform a match that fails using = then a MatchError exception will be raised. For example if you try {x} = 1 in iex you’ll get a match exception. That’s the normal expected behaviour.

But …

In a test where we want to assert that a match occured and it doesn’t then we don’t want the match exception, we want a better error message. So what I think the code is doing is rewriting the match-and-bind expression into a match?/2 call.

That is, its re-writing {x} = 1 into something like match?({x}, 1). That way the assertion will get a Boolean result and it can then accept or refute the assertion and return a better error message.

Papillon6814

Papillon6814 OP

Thank you for explaining that!

— All posts loaded —

Where Next? Top

Trending in Questions Top

Blokh
Hey guys, I’ve got a huge CSV ( around 10 GB ) that needs to be processed hourly Do you guys have any suggestions what is the best prac...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
matt-savvy
Anyone here using Honeybadger? My Honeybadger account is being overwhelmed with noise from some bots. Seeing a lot of Bandit.HTTPError...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews