Papillon6814

Papillon6814

Hello.
I’m reading elixir-lang/elixir for my study. I found a strange point in ExUnit.
That’s this.

defmacro assert({:=, meta, [left, right]} = assertion) do
    code = escape_quoted(:assert, meta, assertion)

    # If the match works, we need to check if the value
    # is not nil nor false. We need to rewrite the if
    # to avoid silly warnings though.
    check =
      suppress_warning(
        quote do
          case right do
            x when x in [nil, false] ->
              raise ExUnit.AssertionError,
                expr: expr,
                message: "Expected truthy, got #{inspect(right)}"

            _ ->
              :ok
          end
        end
      )

    __match__(left, right, code, check, __CALLER__)
  end

I think the right variable should be unquoted.

defmacro my_if(condition, clauses) do
    do_clause = Keyword.get(clauses, :do, nil)
    else_clause = Keyword.get(clauses, :else, nil)
    
    quote do
      case unquote(condition) do
        x when x in [false, nil] ->
          unquote(else_clause)
        _ ->
          unquote(do_clause)
      end
    end
  end

This is my_if function which is written in a book. I don’t know why both my_if and the assert work.

Showing Posts 1 to 7

Aetherus

Aetherus

This clause of assert handles the pattern matching case like

assert foo = bar

where foo is a pattern and bar can be anything.

Remember that atoms keep as is in the code and in the AST, and false and nil are atoms. So, if right is literally nil or false in the code, it is nil or false in the AST, too. And if right is nil or false, the assertion will definitely fail because pattern matching using = always returns the right hand side if it matches the left hand side, or raises an error if it does not match. So, in this specific case, unquote(right) should not be used.

The other cases of pattern matching when right is not literally false or nil is handled by the line

__match__(left, right, code, check, __CALLER__)
Papillon6814

Papillon6814 OP

Thank you for your answer!

Sorry, I’m not sure why it should not be unquoted…
I think variables in quote should occurs an error without being unquoted.

But right in above code is not unquoted. Why it does not occur any errors?

Aetherus

Aetherus

Sorry, It was my misunderstanding of the code in ExUnit.

I stared at the code closely, and saw this:

def __match__(left, right, code, check, caller) do
  ...
  match_expr = ... # It's an AST!!
  
  quote do
    right = unquote(right)  #<---- This line does the trick!
    expr = unquote(code)
    unquote(vars) = unquote(match_expr)
    right
  end
end
Aetherus

Aetherus

By the way, it’s totally OK to access an undeclared variable inside quote, for example, in a brand new IEx session,

iex> quote do: foo
{:foo, [], Elixir}

It does not raise error.

Papillon6814

Papillon6814 OP

Wow that’s true!

I don’t understand why assert function works with the __match__ function… Would you explain why? :sob: :sob:

kip

kip

ex_cldr Core Team

When you try to perform a match that fails using = then a MatchError exception will be raised. For example if you try {x} = 1 in iex you’ll get a match exception. That’s the normal expected behaviour.

But …

In a test where we want to assert that a match occured and it doesn’t then we don’t want the match exception, we want a better error message. So what I think the code is doing is rewriting the match-and-bind expression into a match?/2 call.

That is, its re-writing {x} = 1 into something like match?({x}, 1). That way the assertion will get a Boolean result and it can then accept or refute the assertion and return a better error message.

Papillon6814

Papillon6814 OP

Thank you for explaining that!

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
water
I’m aware of 2 such projects, are there others? git: GitHub - team-alembic/realworld: A fullstack Phoenix LiveView application with back...
New
itzmidinesh
Hi all, I’m working on a Phoenix project where I need to make external HTTP requests and I’m trying to choose between Req and HTTPoison....
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
leoschweizer
Hi, we run different LLM models across a cluster, with each node loading a configurable subset. Model-specific queues let nodes consume ...
New
csmr
Hi all, I’m new here and would like to hear peoples views on my Elixir/Phoenix based game-engine! :smiley: Mutonex gamedesign was finish...
New
perzanko
Do we have maintainer of absinthe-graphql/dataloader here? We have a PR that we’d like to merge to the library. Relatively small additive...
New

Other Trending Topics Top

dominicletz
Hey there, I haven’t seen a list of useful Elixir specific skills for the popular AI tools yet so I’m starting one here with my first. ...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
webofbits
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself. My main conc...
#ai
New
OndrejValenta
(I just needed to vent somewhere and LinkedIn is full of hope, or hype, I’m not sure which exactly) AI dream has many faces, but general...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews