sezaru

sezaru

Hello,

I was wondering, why Phoenix doesn’t follow the “unwritten rule” that your module path should be identical to the file path in the system (ex: MyApp.Bla.Ble would be in lib/my_app/bla/ble.ex) for some of its framework files?

That may sound dumb, but one of the things that I like most about Elixir is the well-defined patterns that everyone uses, variables, atoms and files should use underscore, modules should be camel case, etc. This, IMO, makes the code well organized, easy to read, and easy to find. And in my experience, most of the Elixir libraries follow these patterns (except Google ones, ofc).

At the same time, you have some parts of the Phoenix Framework which seem to ignore this. For example, instead of having MyAppWeb.Controllers.Page which would be stored in lib/my_app_web/controllers/page.ex, we have MyAppWeb.PageController which is stored in lib/my_app_web/controllers/page_controller.ex. The same thing happens with views, components, etc.

I know I’m exaggerating, but this for some reason makes me remember java class names like AbstractSingletonProxyFactoryBean :sweat_smile:

I’m not saying that this is wrong or anything, it mostly depends on the user’s opinion in the end… But at the same time, having the module reflect the file path makes things easy to find and makes, IMO, the language not dependent on IDEs, so this made me wonder why Phoenix does this, I’m pretty sure there is a good reason.

First 2 of 2 Posts Switch mode

LostKobrakai

LostKobrakai

Essentially all parts of my_app_web ignore this.

The reason being is to prevent you having three (or more) page.ex files/….Page modules in your codebase (schema/controller/view/…) which makes it hard to search by filename or module. Given this overlap of names is common place and not a rare occurance it makes sense to break with a convention, given it’s only a convention and not enforced by anything.

sezaru

sezaru OP

Thanks for the explanation @LostKobrakai , that makes sense even though I still prefer having multiple page.ex files tbh.

Probably because I never search for a file in the project but go manually to the file directory, so I never had this problem.

But I guess most people would search for the file, so the current approach would work better for them.

— All posts loaded —

Where Next? Top

Trending in Discussions Top

AstonJ
As the title says, please share what you’ve been up to with Elixir. Whether that’s been learning it, looking into it, making stuff with i...
2977 91898 914
New
AstonJ
The obligatory hello world thread! Who are you and where are you from? :stuck_out_tongue:
4616 55835 594
New
byu
@chrismccord : I just saw the Extract AGENTS.md from Phoenix.new into phx.new generator commit to the phoenix project. My initial shotgu...
New
arcanemachine
I was working on an Ecto migration and I needed a timestamp. So, for the nth time, I looked up the different data types for timestamps, a...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New
alexslade
Fly’s CEO posted this recently - Turn And Face The Strange · The Fly Blog It says that Fly is going all-in on sprites, which is a worry ...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
wintermeyer
There are three potential reasons for members of this forum to have a look at https://vutuv.de You are tired or annoyed of LinkedIn. Yo...
New

We're in Beta

About us Mission Statement