sezaru

sezaru

Hello,

I was wondering, why Phoenix doesn’t follow the “unwritten rule” that your module path should be identical to the file path in the system (ex: MyApp.Bla.Ble would be in lib/my_app/bla/ble.ex) for some of its framework files?

That may sound dumb, but one of the things that I like most about Elixir is the well-defined patterns that everyone uses, variables, atoms and files should use underscore, modules should be camel case, etc. This, IMO, makes the code well organized, easy to read, and easy to find. And in my experience, most of the Elixir libraries follow these patterns (except Google ones, ofc).

At the same time, you have some parts of the Phoenix Framework which seem to ignore this. For example, instead of having MyAppWeb.Controllers.Page which would be stored in lib/my_app_web/controllers/page.ex, we have MyAppWeb.PageController which is stored in lib/my_app_web/controllers/page_controller.ex. The same thing happens with views, components, etc.

I know I’m exaggerating, but this for some reason makes me remember java class names like AbstractSingletonProxyFactoryBean :sweat_smile:

I’m not saying that this is wrong or anything, it mostly depends on the user’s opinion in the end… But at the same time, having the module reflect the file path makes things easy to find and makes, IMO, the language not dependent on IDEs, so this made me wonder why Phoenix does this, I’m pretty sure there is a good reason.

Showing Posts 1 to 2

LostKobrakai

LostKobrakai

Essentially all parts of my_app_web ignore this.

The reason being is to prevent you having three (or more) page.ex files/….Page modules in your codebase (schema/controller/view/…) which makes it hard to search by filename or module. Given this overlap of names is common place and not a rare occurance it makes sense to break with a convention, given it’s only a convention and not enforced by anything.

sezaru

sezaru OP

Thanks for the explanation @LostKobrakai , that makes sense even though I still prefer having multiple page.ex files tbh.

Probably because I never search for a file in the project but go manually to the file directory, so I never had this problem.

But I guess most people would search for the file, so the current approach would work better for them.

— All posts loaded —

Where Next? Top

Trending in Discussions Top

AstonJ
As the title says, please share what you’ve been up to with Elixir. Whether that’s been learning it, looking into it, making stuff with i...
2977 94592 917
New
cblavier
Hey there, It’s been more than a year since we started using LiveView as our main UI library and building a whole library of UI componen...
New
mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
heathen
Quite interesting article Google brought me. Didn’t find any mentions about it here. What do you think in general? Would you use togethe...
New
AstonJ
Since we have deprecated our Erlang sections (as we have dedicated Erlang Forums now) let’s add this thread for those who’d like to post ...
New
maennchen
:warning: Security advisory: Decimal DoS vulnerability A vulnerability has been published for decimal where very large exponents can cau...
New
Null-logic-0
What IDE or editor are you using for Elixir development? Personally, I use Zed, and I really like it, but sometimes I wish there were a ...
New

Other Trending Topics Top

marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
webofbits
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself. My main conc...
#ai
New
webofbits
Aludel - LLM Evaluation Workbench Aludel is an embeddable Phoenix LiveView dashboard for evaluating and comparing LLM prompts across mult...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews