Would the Phoenix maintainers - and the community - welcome a PR adding dark mode with selectors consistently to all phx gen templates?

Phoenix Forum Proposals/Suggestions
, ,
21

Here is what I did on the core component’s input to support dark mode properly using Tailwind’s dark:selector

:point_right: Here is the code diff.

If you think the added code is small enough, I can open a PR on Phoenix to update core_component’s generators.

Before:

image
image1200×1420 74.4 KB

After:

darkmode
darkmode1200×1425 78.3 KB

10 Likes
22

given Chris’s post above, is the status of this “I, cblavier, got this” or would you like any assist?

1 Like
23

note: my goal is not just core components but also:

  • phx.gen motions generate dark mode-enabled templates, especially auth and live
  • possibly default templates
4 Likes
24

Hi Cort, I apologize for any confusion!

I intended to show that implementing dark mode support for core components can be manageable.

However, I believe your approach is more valuable, and I appreciate that it allows for opting out. Please go ahead and open a PR!"

25

will do!

1 Like