Hi @josevalim, I hope you had chance to enjoy some downtime over the holidays.
To re-create the issue, setup the hello world demo:
mix new
Then replace hello_world_test.exs with this:
defmodule HelloWorldTest do
use ExUnit.Case, async:
require ExUnit.DocTest
doctest HelloWorld
test "greets the world" do
assert HelloWorld.hello() == :world
end
end
This runs 1 doctest and 1 test in 1.17.x but fails in 1.18.x
Great you came up with a simple demo.
Wonder what the reason was/is for the boolean missing notation. Imho saving a ‘true’ or ‘false’ is not worth the implicitness, but maybe I miss the point.
@BartOtten There’s no reason except my incompetence. The code was written early in my Elixir journey. At the time my mindset was that use could be doing anything, and it’s in the test code so not released and therefore I don’t need to worry about understanding what it’s doing, or how it works, I just need to know that my tests run. I interpreted async: as a flag, and the tests ran fine. Of course I copied the pattern many times…
The issue is that when I upgraded to 1.18.x my code simply broke, and the message was not especially helpful in tracking down what was wrong. Maybe the macro should insist on a :true or :false value? It is off putting when a minor release breaks your “working” (albeit poor) code in non obvious ways.
This seems to fix it:
diff --git a/lib/ex_unit/lib/ex_unit/case.ex b/lib/ex_unit/lib/ex_unit/case.ex
index 21701d870..09a22449f 100644
--- a/lib/ex_unit/lib/ex_unit/case.ex
+++ b/lib/ex_unit/lib/ex_unit/case.ex
@@ -562,7 +562,7 @@ defmacro __before_compile__(%{module: module}) do
|> Map.new()
opts = Module.get_attribute(module, :ex_unit_module, [])
- async? = Keyword.get(opts, :async, false)
+ async? = !!Keyword.get(opts, :async, false)
group = Keyword.get(opts, :group, nil)
parameterize = Keyword.get(opts, :parameterize, nil)
I haven’t gone through all relevant code yet so there’s probably a better way to fix this. If that seems interesting, please feel free to take over and send a PR!
For the Nix users: Elixir 1.18.1 is now available on the nixpkgs-unstable and nixos-unstable channels, with OTP 27 by default.
Here’s what the elixir package gives you out-of-the-box now:
$ elixir --version
Erlang/OTP 27 [erts-15.2] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit]
Elixir 1.18.1 (compiled with Erlang/OTP 27)
I compiled zigler with 1.18.0 (and 1.18.1) and got a pretty difficult to parse type warning (Type issue with argument error prong causing unmatched case branch · Issue #502 · E-xyza/zigler · GitHub). At roughly 600 lines long for a single value, I thought it might be interesting.
@josevalim Thanks. I think the new message would have made my mistake clear to me. BTW really enjoying Elixir, thanks for the work you’re all doing. HNY
Nice! It would be nice if you could squelch some warnings easier - things like warning: this clause of defp subject_for_env/2 is never used. I’ve tried @compile {:no_warn_unused, subject_for_env/2} but that does not seem to solve it with mix compile --warnings-as-errors for some reason.
@barttenbrinke just a quick check, you used @compile :nowarn_unused_vars i.e. there is no space in :nowarn ?