I wonder if a Credo check could be added for this…
arcanemachine
fuelen
I don’t see how these commas add readability 
It is just different, but not better.
In Elixir you already can add a new line symbol at the beginning of the list and it will do the same:
[
1, 2, 3]
On the other hand, diff won’t be that much simpler. IMO, that’s the problem of diff tools, not the language per se. I highly recommend GitHub - Wilfred/difftastic: a structural diff that understands syntax 🟥🟩 · GitHub if readability is a concern, it also handles more complex cases.
0
dimitarvp
Tried it once, the output was very confusing but it might have been the color scheme. Can you customize it? Or, rather, do you use difftastic and how?
0
sabiwara
Elixir Core Team
I think diffs are one part of the story, but another argument is that it removes friction when re-ordering items by moving lines around as well.
Not a major issue at all, but small pain that could totally be avoided with trailing commas.
The main concern I have with trailing commas is that they are not supported in function arguments, so this might introduce some visual inconsistency perhaps. But since lists / maps have distinct ASTs, I don’t think it’s an issue in practice.
11
fuelen
hauleth
Or do:
git config --global difftool.difftastic.cmd 'difft "$LOCAL" "$REMOTE"'
git config --globa diff.tool difftastic
And then you can just use git difftool when you want Difftastic.
1
dimitarvp
Eiji
The removal of trailing commas in list and map (not calls) is causing trouble a bit especially when you deal with options passed to some macro generator. Think that you want to check something part by part i.e.:
[
key1: :value1,
key2: :value2,
key3: :value3,
# key4: :value4,
# key5: :value5,
]
When you have configured your editor to format file on save then the comma would be removed after :value3. The problem is when you want to uncomment next option(s). Every time I’m doing that I need to add the comma back which is of course simple, but really unnecessary.
Removing a single character does not help at all in my opinion and in some cases it distracts people which is really bad having in mind that Elixir was built with an approach of focus on a work on the actual problem.
11
dimitarvp
Yeah that’s my usual problem – moving stuff in a list. The auto-removal of the comma from the last element always throws a wrench in what should be a near-brainless process.
7
Eiji
Reordering a list, of course! Often when the order does not matter I prefer to have thing sorted alphabetically which often makes a lot of sense in the lists and maps as I can easier find specific key-value pair or a single value. I have F9 shortcut for that in Sublime Text 3 and Zed (with sublime key mapping).
0