Ash Domain functions - best practices / approach

when you define a read action as a code interface you can also pass in a load

e.g. if you have

defmodule Domain do

  resource do
    resource Warehouse do
      define :get_warehouse, action: read, get_by: :id
    end
  end
end


Domain.get_warehouse(id, load: [:tanks]) 

That will give you the warehouse including the tanks

Nothing wrong with writing those functions, just up to you if you need the benefits of a generic action or not Functions are a simple tool and often using a simple tool is good. Since you’re aware of what you can get from generic actions, you can ultimately decide whether or not you need a generic action or not.

I personally error on the side of making generic actions and when I need functions they typically exist for a reason and I group them in some way to indicate that reason. Like if I have common helpers for building a UI I might put those in their own module MyApp.MyDomain.LiveViewHelpers or something along those lines. But when in doubt, finding a way to either extend an existing domain action or create a new one often yields better fruit down in the long run.

Very clear and practical. Many thanks again.