jmurphyweb
Calling View file functions from main app
Given that View modules contain formatting logic, what do you do if you want to format some data in your main application (ie in lib/myapp/ as opposed to in the lib/myapp_web/) ?
We are doing a load of CSV exports, and I keep finding myself aliasing View modules in my library modules which feels dirty.
How do you handle this? Do you have any self-enforced rules about which modules can call others? I’d love to hear about them!
Marked As Solved
mindok
Picking the right CSS class for given application state, conditionally showing username or “not logged in”, fiddling around with consistent CSS classes for inputs/buttons etc is something that I would put in a view module.
Also one-off stuff, like expanding a list in your assigns into a comma-separated list for display.
I see it as the final step to tidy things up so template code is more readable.
On the Phoenix docs overview page, the list is a little more terse than the description above:
- render templates
- act as a presentation layer
- define helper functions, available in templates, to decorate data for presentation
Things like formatting phone numbers, addresses, currency etc are probably more business related. They can end up in email notifications, data exports, reports etc. They would most likely live in the app data modules (as per @lud suggestion) or in other modules depending on their complexity.
Ultimately here’s no hard and fast rules. One of the nice things about functional programming is it makes it relatively easy to move things around as your application grows or you discover module dependencies that no longer make sense. You put something into a function and a formatted thing comes out with no unpredictable side effects, so you can move that function elsewhere with relative ease.
Also Liked
dimitarvp
Oops, sorry for the derp. ![]()
In all Phoenix projects where I had any influence, I always moved such functions outside the _web namespace. They absolutely don’t belong there in my eyes. They are also not views per se, they are like data reshapers / transformers / whatever-you-want-to-call them.
So yep, move them to the other namespace and don’t have a care in the world. ![]()
mindok
From the docs (https://hexdocs.pm/phoenix/views.html)
“Phoenix views have two main jobs. First and foremost, they render templates (this includes layouts). The core function involved in rendering, render/3 , is defined in Phoenix itself in the Phoenix.View module. Views also provide functions which take raw data and make it easier for templates to consume. If you are familiar with decorators or the facade pattern, this is similar.”
jmurphyweb
Thanks for the reply @dimitarvp
I am using view logic to format the data in the same way as we do in our templates.
Here is a trivial example:
# in controller
def csv_users(conn, params) do
binary = Accounts.buid_users_csv_export()
send_download(conn, binary: binary)
end
# in Accounts.Users.ExportCSV
def buid_users_csv_export() do
Users.list_users()
|> Enum.map(fn user ->
[
UserView.format_name(user),
UserView.format_address(user),
...
]
|> NimbleCSV.build_csv()
end
This is a really basic example of pseudo code but it is exactly the issue that I am facing in many places in my application. In reality, there is too much formatting to just redefine the functions locally to this module.
Any help really appreciated ![]()
Popular in Discussions
Other popular topics
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #websockets
- #supervisor
- #advent-of-code
- #elixirconf-us
- #distillery
- #processes
- #forms
- #api
- #metaprogramming
- #security
- #performance








