sebsel
Match on the end of a pipe (Matchpipe?)
So I have looked for this topic and found similar ones but not actually this one. Forgive me if I missed it.
While I really love Elixirs pipelines, I see myself writing this pattern from time to time:
def some_function(start) do
result =
start
|> Enum.map(&do_something/1)
|> Enum.filter(&but_without_these/1)
{:ok, result}
end
For this pattern, people seem to have come up with operators that do things with second or last arguments (I found one of those discussions). I’m not really interested in that, I want to make another point.
In the above pattern, I start reading about a result, then I see start, and then the actions that lead to start. Your eyes notice the pipeline quite fast, you see what happens, but especially when the action after the pipeline is more complicated, you start asking yourself: wait, what did they call the result of this pipeline? To find out, you have to go all the way up to read the variable name.
Put in another way: this way of writing messes with the ordering in which things are happening. First, the start is evaluated, then the pipeline is run, and only after that the match is completed which gives result a value.
I think it would be nice to be able to write it like this:
def some_function(start) do
start
|> Enum.map(&do_something/1)
|> Enum.filter(&but_without_these/1)
>>> result
{:ok, result}
end
This removes some indentation and reads nicely in order of what happens when. It might even stop the questions for |2>? You can just start a new pipeline after the first one with this variable where-ever you want.
Oh, and it’s a pattern match, so it’s quite powerful, as you know.
def some_function(start) do
start
|> Enum.map(&do_something/1)
|> Enum.filter(&but_without_these/1)
>>> [first | _]
Enum.zip(start, first)
|> Enum.reduce(&more_transforms/1)
>>> result
{:ok, result}
end
Note: I used >>> here because it’s one of the available custom operators, but I think => would be prettier (but probably taken) or <| (but that’s not available). Here’s a very naive macro to make it work:
defmacro left >>> right do
{:=, [], [right, left]}
end
Again, if this has been proposed too many times, please pardon the intrusion ![]()
Most Liked
OvermindDL1
There are all kinds of useful libraries and patterns, but if you want to stick with stock Elixir then I would do (and do) this:
def some_function(start) do
start
|> Enum.map(&do_something/1)
|> Enum.filter(&but_without_these/1)
|> case do result ->
{:ok, result}
end
end
I use that |> case do result -> ... end pattern a lot. I know that not everyone likes it but I find it significantly more readable then misplaced variable definitions. Now if only we had proper monad’y do blocks without a library. ^.^;
OvermindDL1
For non-kernel things I use the Exceptional library most often, so with it then it would be:
def some_function(start) do
start
|> Enum.map(&do_something/1)
|> Enum.filter(&but_without_these/1)
|> to_tagged_status()
end
But the case way is useful for ‘generic’ handling of the value without needing to make a new function (which you should always do, but I generally don’t if it’s only a line or two in size and just use the case instead). ![]()
EDIT: For note, to_tagged_status/1 is a lot more than just an &{:ok, &1}.() wrapper, it returns either an :ok or :error tuple depending on the value. If the value is an exception then it wraps it’s exception message in the :error tuple. If it’s already an error or ok tuple then it passes it through unchanged.
iex(devserver2@127.0.0.1)9> 42 |> to_tagged_status()
{:ok, 42}
iex(devserver2@127.0.0.1)10> nil |> to_tagged_status()
{:ok, nil}
iex(devserver2@127.0.0.1)11> {:ok, :blah} |> to_tagged_status()
{:ok, :blah}
iex(devserver2@127.0.0.1)12> Enum.OutOfBoundsError.exception("error message") |> to_tagged_status()
{:error, "error message"}
iex(devserver2@127.0.0.1)13> {:error, :blorp} |> to_tagged_status()
{:error, :blorp}
I quite like the style of returning ok/error tuples, raw ok values, or exceptions. It is quite useful I’ve found. ![]()
michalmuskala
Some, including me, do consider it rather unreadable
. I’d much rather see:
result =
start
|> Enum.map(&do_something/1)
|> Enum.filter(&but_without_these/1)
{:ok, result}
or even
{:ok,
start
|> Enum.map(&do_something/1)
|> Enum.filter(&but_without_these/1)}
Popular in Discussions
Other popular topics
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #websockets
- #supervisor
- #advent-of-code
- #elixirconf-us
- #distillery
- #processes
- #forms
- #api
- #metaprogramming
- #security
- #performance









