rugyoga

rugyoga

I recently published the Audit library (described in another thread, hex, github).
It required capturing the current value of __ENV__ at the call-site,
so it had to be implemented as a macro. But it has the potential to create
space leaks, I wanted it turned off by default.
So the idea was to have two versions of the macro:

 @enabled? Application.compile_env(:audit, :enabled?, false)
 @key :__audit_trail__
...
  @spec payload(struct(), Macro.Env.t()) :: trail_t()
  def payload(r, e), do: {r, e.file, e.line} 
...
  @dialyzer {:nowarn_function, audit_fun: 2}
  @spec audit_fun(struct(), Macro.Env) :: struct()
  def audit_fun(r, e) do
    r |> struct([{@key, payload(r, e)}])
  end
...
  if @enabled? do
    defmacro audit(record) do
      quote generated: true do
        unquote(__MODULE__).audit_fun(unquote(record), __ENV__)
      end
    end
  else
    defmacro audit(record) do
      quote generated: true do
        unquote(record)
      end
    end
  end

And in the code that uses it, a compile-time decision is made as to whether
to include the __audit_trail__ field that it relies on for book-keeping.

I have two problems:

  1. when the option is turned on, I get lots of dialyzer errors at the places
    where the audit macro is used where:
%Foo{ x | bar: value }

is changed to:

%Foo{ audit(x) | bar: value }

to leverage the library.

It’s either:
Function ... will never be called.
or
Function ... has no local return.
or
The created anonymous function has no local return.

  1. Our CI pipeline mysteriously crashes while parallel compiling the Elixir code leaving no usable errors. (Is there a way to run the compiler single-threaded so we can at least isolate which file it’s crashing on?)

Am I doing something obviously wrong in my approach?
Somewhat baffled.

Showing Posts 1 to 2

msimonborg

msimonborg

For #1, try changing Macro.Env to Macro.Env.t in your specs. Essentially you are telling dialyzer than it should expect the atom Macro.Env as an argument, instead of the struct

rugyoga

rugyoga OP

Same errors, alas.

— All posts loaded —

Where Next? Top

Trending in Questions Top

Blokh
Hey guys, I’ve got a huge CSV ( around 10 GB ) that needs to be processed hourly Do you guys have any suggestions what is the best prac...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
Onor.io
I have what I’ve heard referred to as a “lookup table” in my database. This is a way of assigning codes to common values. One common lo...
New
Trolleger
What approach to take when sending live updates to “random” users Hi! I have a question, I have a little chat app, and when I create a DM...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
matt-savvy
Anyone here using Honeybadger? My Honeybadger account is being overwhelmed with noise from some bots. Seeing a lot of Bandit.HTTPError...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
wintermeyer
There are three potential reasons for members of this forum to have a look at https://vutuv.de You are tired or annoyed of LinkedIn. Yo...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews