loics2

loics2

Hi, I’m slowly losing my mind about a bug with liveview on iOS.

Users on my application are members of organizations, and the homepage is the organization’s page. If a user is logged in and a member of the organization, it gets redirected to the management side of the application. This part of the application is protected with the standard plugs and mount hooks to check if the user is logged in, a member and have the required permissions.

Some users cannot access the management page on iOS because they are trapped in a redirect loop, and I cannot find what causes this issue. I’m almost certain it affects only iOS users, and I could not reproduce the bug on LambdaTest, on any version of iOS.

Here are the interesting part of my router:

# Routes unavailable to authenticated users
scope "/", NyghtWeb do
  pipe_through [:browser, :redirect_if_user_is_authenticated]

  live_session :redirect_if_user_is_authenticated,
    on_mount: [OrganizationHook, {NyghtWeb.UserAuth, :redirect_if_user_is_authenticated}],
    session: {Session, :session, []} do
    live "/users/log_in", UserLive.Login, :new
  end

  post "/users/log_in", UserSessionController, :create
end

# Routes requiring authentication
scope "/app", NyghtWeb do
  pipe_through [:browser, :require_authenticated_user]

  live_session :require_authenticated_org_user,
    on_mount: [OrganizationHook, {NyghtWeb.UserAuth, :ensure_authenticated}],
    layout: {NyghtWeb.UI.Layouts, :app_admin},
    session: {Session, :session, []} do

    scope "/events", EventLive do
      live "/", IndexList, :upcoming
    end
end

# Routes that don't require authentication
scope "/", NyghtWeb do
  pipe_through [:browser]

  live_session :optional_authenticated_user,
    on_mount: [OrganizationHook, {NyghtWeb.UserAuth, :mount_current_user}],
    session: {Session, :session, []} do
    live "/", OrganizationLive.Show, :index, as: :home
  end
end

Here are some of the liveview on_mount hooks:

# redirects a user if it's a member of the organization, used on the homepage
def on_mount(:redirect_if_user_is_member, _params, session, socket) do
  socket = mount_current_user(socket, session)

  with {:ok, user} <- Map.fetch(socket.assigns, :current_user),
       true <- Organizations.member?(socket.assigns.current_organization, user) do
    Logger.info("Redirecting user, page is not available for organization member (LV)")
    {:halt, Phoenix.LiveView.redirect(socket, to: ~p"/app/events")}
  else
    _ ->
      {:cont, socket}
  end
end

# generated by phx.gen.auth with added logging
def on_mount(:ensure_authenticated, _params, session, socket) do
  socket = mount_current_user(socket, session)

  if socket.assigns.current_user do
    {:cont, socket}
  else
    Logger.warning("Current user not found, unauthorized access (LV)")

    socket =
      socket
      |> Phoenix.LiveView.put_flash(:error, "You must log in to access this page.")
      |> Phoenix.LiveView.redirect(to: ~p"/users/log_in")

    {:halt, socket}
  end
end

# also generated with phx.gen.auth with added logging
def redirect_if_user_is_authenticated(conn, _opts) do
  if conn.assigns[:current_user] do
    Logger.info("Redirecting user, page is not available for authenticated users (plug)")

    conn
    |> redirect(to: signed_in_path(conn))
    |> halt()
  else
    conn
  end
end

Finally, here are some logs when a user is stuck in a loop:

[INFO] GET /
[INFO] Redirecting user, page is not available for organization member (LV)
[INFO] Sent 302 in 13ms
[INFO] GET /app/events
[INFO] Sent 200 in 28ms
[INFO] CONNECTED TO Phoenix.LiveView.Socket in 22µs Transport: :websocket Serializer: Phoenix.Socket.V2.JSONSerializer parameters: %{"_csrf_token" => "<token>", "_live_referer" => "undefined", "_mounts" => "0", "_track_static" => %{"0" => "...", "1" => "..."}, "timezone" => "Europe/Zurich", "vsn" => "2.0.0"}
[WARN] Current user not found, unauthorized access (LV)
[INFO] GET /users/log_in
[INFO] Redirecting user, page is not available for authenticated users (plug)
[INFO] Sent 302 in 5ms
[INFO] GET /
...

Does anybody have an idea of what’s happening?

Thanks!

First 6 of 6 Posts Switch mode

mindok

mindok

Is it in a WebView inside an iOS app, or Safari?

loics2

loics2 OP

Most of users are using Safari, but a few are using chrome

mindok

mindok

If this is a test system I’d break it down into steps to isolate what’s going on.

Maybe redirect to a liveview (instead of “/app/events”) that is available whether authed or not to confirm whether user details get passed through properly via session, and also try sending it to a dead view (view/controller) page to confirm whether user details get added to the conn assigns.

Once you’ve isolated exactly where auth details are getting lost it may be a bit easier to troubleshoot.

codeanpeace

codeanpeace

Sounds frustrating to say the least… here’s an attempt to recap this redirect loop based on the logs.

  1. GET / => live "/", OrganizationLive.Show, :index, as: :home
    where true <- Organizations.member?(socket.assigns.current_organization, user)
    in on_mount(:redirect_if_user_is_member, ...)
    matches so user is redirected to /app/events

  2. /app/events => live "/", IndexList, :upcoming
    where if socket.assigns.current_user do
    in on_mount(:ensure_authenticated, ...)
    is falsey so user is redirected to live "/users/log_in"

  3. live /users/log_in => UserLive.Login
    where if conn.assigns[:current_user] do
    in redirect_if_user_is_authenticated/2
    is truthy so user is redirected to signed_in_path(conn)
    and this then goes back to the step 1 with GET /
    since mix phx.gen.auth adds defp signed_in_path(_conn), do: ~p"/" in the UserAuth module

So the user stuck in a loop somehow meets the following conditions:

# Step 1
Organizations.member?(socket.assigns.current_organization, user)` => truthy
# Step 2
socket.assigns.current_user => falsey
# Step 3
conn.assigns[:current_user] => truthy

It seems like Step 2 should be truthy as well, but is not for some mysterious reason.

What does your mount_current_user/2 and Organizations.member/2 functions look like? As a sanity check, I’d investigate whether the former is somehow returning nil which could be a problem if the latter somehow returns true when passed a nil as a user.

yasoob

yasoob

I don’t have any solution to your problem but I wanted to share that I was facing similar auth related issues with a LiveView app. In my case, the iOS version was very old and I think there was probably some feature that iOS didn’t support (that is required by LV). As soon as I upgraded the iOS version, the issue automatically resolved. To this day I have no clue what was the root-cause.

Maybe ask the client to update the iOS version if they are on a pretty old version. I know it is an unrealistic ask in certain circumstances but maybe it is a viable solution for you?

ibarch

ibarch

Can you try to remove :require_authenticated_user form pipe_through list?
During the initial HTTP call both :require_authenticated_user and {NyghtWeb.UserAuth, :ensure_authenticated} are called. I assume that these two are doing similar authentication/authorization job and may cause the issue.

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
roeland
Kia ora, We have been using elixir-google-api to connect to Google Drive. However, with the updates to Tesla due to CVEs this is now bro...
New
rahultumpala
Hello, I have an Elixir backend that implements a custom protocol over TCP. I want to load test the backend and assess the performance o...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New

We're in Beta

About us Mission Statement