bartblast

bartblast

Creator of Hologram

Why comparing atoms gives typing violation warning?

consider:

defmodule MyModule do
  def test do
    :a < :b
  end
end

mix compile my_module.ex

gives a warning:

Compiling 1 file (.ex)
    warning: comparison between incompatible types found:

        :a < :b

    While Elixir can compare across all types, you are comparing across types which are always distinct, and the result is either always true or always false

    typing violation found at:
    │
  3 │     :a < :b
    │        ~
    │
    └─ my_module.ex:3:8: MyModule.test/0

Showing Posts 1 to 10

tcoopman

tcoopman

What’s the result you expected? What are you trying to do?

antoine-duchenet

antoine-duchenet

Because :a and :b are not considered to be of type atom() but respectively as type :a and :b.

LostKobrakai

LostKobrakai

And as mentioned in the warning the result of the comparison is static as well.

bartblast

bartblast OP

Creator of Hologram

Since the < operator is inlined with :erlang.</2, I expected the compiler to resolve its typing to a parametric polymorphic definition, something akin to (a, a) -> boolean() when a: term(). I didn’t expect singleton types.

I gave a simplified example to illustrate the problem, which I encountered when implementing client-server consistency tests in Hologram. Basically, I test whether manually transpiled Erlang functions behave exactly the same as their server counterparts.

LostKobrakai

LostKobrakai

If the typesystem has distinct types, why would it fall back to less specific types? This would be different if you would have variables here, but you hardcoded values for the comparison.

bartblast

bartblast OP

Creator of Hologram

@antoine-duchenet @LostKobrakai Guys, considering your previous answers, does this mean that Erlang functions are not treated as “atomic” functions for the type system and they don’t have hardcoded typings? Or maybe the underlying Erlang functions’ abstract code (or bytecode) is analysed as well in the process to determine the typings?

LostKobrakai

LostKobrakai

Not sure I get what you’re asking for, but I don’t think there’s much to it.

With 1.17 warnings where implemented to warn when comparisons are made between different types of data – mostly to warn for the common footgun of comparing structs like DateTime, which would use structural comparison not semantic one. That’s the source of the warning.

The reason for getting the warning if both sides are atoms comes from the fact that the new typesystem implementation considers atom() a divisable type, which includes all possible individual atoms. So :a and :b are distinct types based on the typesystem, but both are part of atom(). The wording sounds a bit unfortunate here though given it’s a bit ambiguous what type of “type” the error refers to.

dimitarvp

dimitarvp

He’s probably asking about BIFs and such.

LostKobrakai

LostKobrakai

BIFs are a runtime/implementation concern though. The compiler (and the typesystem) generally don’t care about any of that.

dimitarvp

dimitarvp

So your functions that call them would never be type-checked by Dialyzer whether they pass the right types of arguments to BIFs, is that what you’re saying?

Where Next? Top

Trending in Questions Top

Blokh
Hey guys, I’ve got a huge CSV ( around 10 GB ) that needs to be processed hourly Do you guys have any suggestions what is the best prac...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
Onor.io
I have what I’ve heard referred to as a “lookup table” in my database. This is a way of assigning codes to common values. One common lo...
New
Trolleger
What approach to take when sending live updates to “random” users Hi! I have a question, I have a little chat app, and when I create a DM...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
matt-savvy
Anyone here using Honeybadger? My Honeybadger account is being overwhelmed with noise from some bots. Seeing a lot of Bandit.HTTPError...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
wintermeyer
There are three potential reasons for members of this forum to have a look at https://vutuv.de You are tired or annoyed of LinkedIn. Yo...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews