IslandUsurper
I’ve just come across a library that had import Foo.BinaryUtils, warn: false peppered through it. That looked like a code smell so I started investigating. It turned out this module had macros in it used for bitstring specifiers, e.g.:
defmacro uint do
quote do: little - unsigned - 16
end
defmacro udint do
quote do: little - unsigned - 32
end
And these are used like so:
<<foo::uint(), bar::udint(), rest::binary>>
My question is why does this not work with require? Shouldn’t it? The library authors used warn: false because the module only contains these macros, and elixirc complains that the import is not used otherwise.
Where Next?
Trending in Questions
Other Trending Topics
Latest on Elixir Forum
Sponsor Spotlight
Catch errors, track performance, monitor hosts and more.
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #blog-post
- #phoenix_html
- #iex
- #graphql
- #ai
- #genstage
- #elixirconf-us
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #metaprogramming
- #security
- #hex
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Error tracking, logs, uptime, and Just Enough APM. Built for developers.
Practical resources that improve the lives of professional developers.
Enabling companies to succeed by building software people love.
The deployment platform built for Elixir: PaaS ease, VPS control.
The team behind Membrane, Popcorn, LiveDebugger. Available for hire.
Courses that'll move you from confusion to "Aha, now I get it!"
Showing Posts 1 to 6- Show Best Posts
- Show All Posts (oldest first)
- Show All Posts (newest first)
IslandUsurper
Turns out I was misunderstanding how
requireandimportwork. What this library should have been doing isimport Foo.BinaryUtils, only: :macros, which communicates much more clearly the intent.eksperimental
Elixir will not complain if you don’t not use all the macros from an imported module. It may be complaining because you are not using any at all.
Feel free to share some code, either gist or a repo and I can have a look at it and give you a more informed answer.
IslandUsurper
It’s definitely using the macros. Taking out the
importprevents compilation, and the error shows where the macro is used. And I just found out that the warning still happens if I replacewarn: falsewithonly: :macros. The repo is Scrub, but I didn’t write it.eksperimental
Where is the specific line of code I should look at?
IslandUsurper
Lots of examples, but lib/scrub/session/protocol.ex:28 and following is a good one to look at.
IslandUsurper
Gah, never mind. It’s the lib/scrub.ex where the warning happens, but that module doesn’t actually use the macros. Everything works as intended.