widianto

widianto

I think I’ve found a small improvement I could contribute to <%= web_namespace %>.CoreComponents (installer/templates/phx_web/components). I need a feature that isn’t available yet.

A noob question about contributing to Phoenix:

I’ve contributed to other open source projects before (translations and a few code changes), but this would be my first contribution to Phoenix.

  • Should I discuss the idea first before opening a pull request, or is it okay to submit one directly?
  • I searched the test suite but couldn’t find tests for core_components.ex template. Should I and where to include tests with the PR?

Thanks! Any advice or contribution guidelines would be greatly appreciated.

Most Liked

jswanner

jswanner

From CONTRIBUTING.md:

Feature requests

Feature requests are welcome and should be discussed on the Phoenix subforum. But take a moment to find out whether your idea fits with the scope and aims of the project. It’s up to you to make a strong case to convince the community of the merits of this feature. Please provide as much detail and context as possible.

The generated code is tested by generating apps and running the generated tests, that said none of those test core components it seems

rhcarvalho

rhcarvalho

Describing the intention here would be a good next step :slight_smile:

In general, the generated CoreComponents are meant as a starting point and only implement a minimal set of functionality.

The intention is that people do change that file in their own projects as the need arises. It demonstrates a pattern and how to work with HEEx, forms, etc.

I’m saying that because my experience has been that the Phoenix team would be willing to accept bug fixes, but less likely to adopt say a completely custom new component.

LostKobrakai

LostKobrakai

It’s also not some arbitrary minimal set, but meant to support just the markup used, generated or encountered by the phoenix generators.

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews