widianto
I think I’ve found a small improvement I could contribute to <%= web_namespace %>.CoreComponents (installer/templates/phx_web/components). I need a feature that isn’t available yet.
A noob question about contributing to Phoenix:
I’ve contributed to other open source projects before (translations and a few code changes), but this would be my first contribution to Phoenix.
- Should I discuss the idea first before opening a pull request, or is it okay to submit one directly?
- I searched the test suite but couldn’t find tests for
core_components.extemplate. Should I and where to include tests with the PR?
Thanks! Any advice or contribution guidelines would be greatly appreciated.
Where Next?
Trending in Questions
Other Trending Topics
Latest Phoenix Threads
Latest on Elixir Forum
Sponsor Spotlight
Supporting innovation across the BEAM ecosystem.
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #blog-post
- #phoenix_html
- #iex
- #graphql
- #ai
- #genstage
- #elixirconf-us
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #metaprogramming
- #security
- #hex
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Error tracking, logs, uptime, and Just Enough APM. Built for developers.
Practical resources that improve the lives of professional developers.
Develop your skills with books, videos, and courses.
The deployment platform built for Elixir: PaaS ease, VPS control.
The team behind Membrane, Popcorn, LiveDebugger. Available for hire.
Courses that'll move you from confusion to "Aha, now I get it!"
Showing Posts 1 to 5- Show Best Posts
- Show All Posts (oldest first)
- Show All Posts (newest first)
jswanner
From CONTRIBUTING.md:
The generated code is tested by generating apps and running the generated tests, that said none of those test core components it seems
widianto
Thanks for your answer. It gave me some clues about where to look for more information.
rhcarvalho
Describing the intention here would be a good next step
In general, the generated CoreComponents are meant as a starting point and only implement a minimal set of functionality.
The intention is that people do change that file in their own projects as the need arises. It demonstrates a pattern and how to work with HEEx, forms, etc.
I’m saying that because my experience has been that the Phoenix team would be willing to accept bug fixes, but less likely to adopt say a completely custom new component.
widianto
Thanks for your answer! I understand now why it should stay lean and minimal.
I originally thought supporting a
classattribute by default would better showcase Phoenix’s flexibility.Thanks for sharing your experience, it was really helpful.
LostKobrakai
It’s also not some arbitrary minimal set, but meant to support just the markup used, generated or encountered by the phoenix generators.