Gupta

Gupta

I was working on a Question which was ,

Input - A list of numbers - [1,2,3,4,5] example

We have to produce the subsets of this list and display those subsets whose sum is equal to 10

Output Format - [ [1,2] , [2,3] , [4,5,6] ] example

Means we have to append those subset in a list whose sum is 10 and make a nested list and print it as an output.

here is my code ..

defmodule Combination do
  def combine([]) do
    []
  end
  def combine([head | tail]) do
    tail_combinations = combine(tail)
    merged_combinations = Enum.map(
      [[]] ++ tail_combinations,
      fn c -> c ++ [head] end
    )
    tail_combinations ++ merged_combinations
  end

#Main thing I am doing here, i am Checking the sum of the subsets but unable to append the list of subset into another list and print the final list

  def display(lis) do
    a=[]
    for vale <- Combination.combine(lis) do
      if Enum.sum(vale)==6 do
        a=a++[vale]
      end
    end
    IO.inspect(a)
  end
end
Combination.display([1,2,3,4])

Error :

erts@eyrc:~/fr_task0_9999/.vscode$ elixir practice.exs
warning: variable "a" is unused (if the variable is not meant to be used, prefix it with an underscore)
  practice.exs:17: Combination.display/1

[]
erts@eyrc:~/fr_task0_9999/.vscode$ 

Can anyone help me i am new to elixir and i got stuct at this point.
Tell me how can i append the list in another list and print the whole list at once .

thank you

First 10 of 21 Posts Switch mode

tomkonidas

tomkonidas

variable are immutable, you would need to use something like Enum.reduce.

def display(list) do
  list
  |> Combination.combine()
  |> Enum.reduce([], fn val, acc ->
    if Enum.sum(val) == 6 do
      [val | acc]
    else
      acc
    end
  end)
end

To display the list you could just pipe the result to IO.inspect

Combination.display([1,2,3,4]) |> IO.inspect()

I think this should give you what you want but looking at your combine, you might neet to reverse order some things.

I get the following output with your combine and my display:

iex> Combination.display([1,2,3,4,5])
[[3, 2, 1], [5, 1], [4, 2]]
Gupta

Gupta OP

Thanks a Lot Brother , i was stuct in this for last 3days

kokolegorille

kokolegorille

This is a typical code, just not for FP.
There is also a problem of scope, everything inside a do end block, will never make its way to the surrounding block.

Gupta

Gupta OP

I am facing another problem with the output
i.e this

when ever my
input is like - [1,2,3,4,5,6,7] , it gives me like this :-

erts@eyrc:~/fr_task0_9999/.vscode$ elixir practice.exs
[[4, 3, 2, 1], [7, 2, 1], [6, 3, 1], [5, 4, 1], [5, 3, 2], [7, 3], [6, 4]]
erts@eyrc:~/fr_task0_9999/.vscode$ 

And when i input something like this- [3, 5, 2, 7, 4, 2, 3] it gives me this :-

erts@eyrc:~/fr_task0_9999/.vscode$ elixir practice.exs
[
  [2, 5, 3],
  [2, 5, 3],
  [3, 2, 2, 3],
  [7, 3],
  [3, 4, 3],
  [3, 2, 5],
  [3, 2, 5],
  [3, 7]
]
erts@eyrc:~/fr_task0_9999/.vscode$ 

After puting several list i noticed that when ever my list is having repeating numbers like - [3, 5, 2, 7, 4, 2, 3] this

it shows like second one , but this not happens every time.

my code is this :

defmodule Combination do
  def combine([]) do
    []
  end
  def combine([head | tail]) do
    tail_combinations = combine(tail)
    merged_combinations = Enum.map(
      [[]] ++ tail_combinations,
      fn c -> c ++ [head] end
    )
    tail_combinations ++ merged_combinations
  end
  def display(list,v) do
    list
    |> Combination.combine()
    |> Enum.reduce([], fn val, acc ->
      if Enum.sum(val) == v do
        [val|acc]
      else
        acc
      end
    end)
    |>IO.inspect()
  end
end
Combination.display([3, 5, 2, 7, 4, 2, 3],10 )

I want the output in linear format like this - [[1,2], [3,4], [5,6]]

tomkonidas

tomkonidas

Maybe it would be easier if you could explain what your combine/1 is supposed to be doing. As in what do you expect the outcome to be when calling that function with a list of integers. We might be able to better help if we understand the reason for the function and not just the output

Gupta

Gupta OP

basically my combine/1 is creating subset of the given list
actually i have taken this code from internet
and yes i think the output of my combine is affecting the output of my display/1
this is what i get from my combine/1

Combination.combine([1,2,3,4])|>IO.inspect()
erts@eyrc:~/fr_task0_9999/.vscode$ elixir practice.exs
[
  [4],
  [3],
  [4, 3],
  [2],
  [4, 2],
  [3, 2],
  [4, 3, 2],
  [1],
  [4, 1],
  [3, 1],
  [4, 3, 1],
  [2, 1],
  [4, 2, 1],
  [3, 2, 1],
  [4, 3, 2, 1]
]
Combination.combine([1,2,3])|>IO.inspect()
erts@eyrc:~/fr_task0_9999/.vscode$ elixir practice.exs
[[3], [2], [3, 2], [1], [3, 1], [2, 1], [3, 2, 1]]
erts@eyrc:~/fr_task0_9999/.vscode$ 

So can u tell me why this is happening ??
:thinking:

tomkonidas

tomkonidas

Are you maybe looking for something like Enum.chunk_every/2?

iex> Enum.chunk_every([1, 2, 3, 4, 5, 6], 2)
[[1, 2], [3, 4], [5, 6]]
tcoopman

tcoopman

You’re saying display the subsets with a sum of 10, but the sums you’re outputting is 3, 5, 15?

Gupta

Gupta OP

I was just giving u the example of output format

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
silverdr
Using Phoenix.LiveView.TagEngine as an EEx.Engine is deprecated! To compile HEEx, use Phoenix.LiveView.TagEngine.compile/2 instead. Sta...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
michallepicki
I am using Oban and occasionally, shortly after a deployment, a handful of jobs can fail because of dependency on other parts of the syst...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New

We're in Beta

About us Mission Statement