tugayac

tugayac

Hey folks :waving_hand:,

I’m one of the maintainers of the Lotus Web library and we had a request to add i18n support for the library. The requester was nice enough to help with a PR here, but I’m having issues getting it to work locally.

If anyone has experience adding Gettext support to libraries, I could use some help understanding the following (posting here because I don’t believe this is a Phoenix-related issue):

  1. Why would Gettext not pick up the correct translations, even though the locale seems to be set correctly in the LiveView process? (see PR comment for details)
  2. Are we adding Gettext support to Lotus Web in the right way, with the goal of allowing users of the library to provide their own translations?
  3. Is there a recommended way of adding Gettext to Elixir libraries? (I couldn’t find any suggestions in the Gettext docs).

Here’s a diff of what I’m trying (also included in the PR discussion) in another Elixir app that uses this branch:

diff --git a/config/config.exs b/config/config.exs
index 5062c76e..32e717e0 100644
--- a/config/config.exs
+++ b/config/config.exs
+config :lotus_web, Lotus.Web.Gettext,
+  priv: "priv/lotus_gettext",
+  locales: ~w(en tr),
+  default_locale: "tr"
+
 import_config "#{config_env()}.exs"
diff --git a/lib/accomplish_web/router.ex b/lib/accomplish_web/router.ex
index 951b8e80..defb9e4c 100644
--- a/lib/accomplish_web/router.ex
+++ b/lib/accomplish_web/router.ex
@@ -48,7 +48,7 @@ defmodule AccomplishWeb.Router do
   scope "/admin", AccomplishWeb.Admin do
     pipe_through :admin
 
-    lotus_dashboard("/lotus")
+    lotus_dashboard("/lotus", on_mount: [{AccomplishWeb.LocaleHook, :default}])
   end
diff --git a/mix.exs b/mix.exs
index ffd13aab..e1e36812 100644
--- a/mix.exs
+++ b/mix.exs
@@ -87,7 +87,7 @@ defmodule Accomplish.MixProject do
-      {:lotus_web, "~> 0.6.2"},
+      {:lotus_web, path: "../lotus_web_branch"},

Here’s the Gettext directory structure in my app:


For reference, default_domain in the PR (for the Lotus Web library) is set to lotus, hence lotus.po.

First 4 of 4 Posts Switch mode

derek-zhou

derek-zhou

Each of the libraries from the dependency is a OTP application with it’s own priv dir, and priv/gettext dir. So, I am not sure if you can achieve e your goal of “allowing users of the library to provide their own translations”. Translations are supposed to be faithful; so can you just accept the translation upstream?

tugayac

tugayac OP

Good point, hadn’t considered that :light_bulb:, we do set otp_app to Lotus Web when using Gettext.

It sounds like the best course of action is just to include it as part of the library as you suggested :+1: I get the feeling we’re trying to use Gettext in a way it wasn’t intended right now.

We could use the dynamic translation features of Gettext, but I do want to keep the compile-time guarantees to avoid breaking translations.

Thanks @derek-zhou :folded_hands:

LostKobrakai

LostKobrakai

This is not as simple. Any of your users has lotus_web as a dependency. Their app won’t start compiling before lotus_web has been fully compiled. You could force a dependency cycle and start compiling parts of their app (gettext backend) before the rest of their app, which might be fine, but also depending on their setup could just as much not be fine at all. If you really want you could add a config to your application, which allows to switch out the folder, where .po files are located. That would allow users to change the translations without messing with the compile time ordering of elixir files.

Given the context I’d probably agree with the suggestion to keep the translations as part of the package though. I can see users wanting to have the UI localized, but less so the ask for customizing the localizations beyond what would be useful to all users.

tugayac

tugayac OP

@LostKobrakai I was referring to using the Gettext functions instead of macros when I said “dynamic translation features of Gettext” (i.e. this section of the Gettext docs), in which case the compile order shouldn’t matter (because translations should be fetched at runtime, but maybe I misunderstand how Gettext works?).

With Gettext macros, yes what you said makes sense :+1:

Given the context I’d probably agree with the suggestion to keep the translations as part of the package though. I can see users wanting to have the UI localized, but less so the ask for customizing the localizations beyond what would be useful to all users.

Yep, we decided to go that direction :slightly_smiling_face:

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
roeland
Kia ora, We have been using elixir-google-api to connect to Google Drive. However, with the updates to Tesla due to CVEs this is now bro...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
rahultumpala
Hello, I have an Elixir backend that implements a custom protocol over TCP. I want to load test the backend and assess the performance o...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New

We're in Beta

About us Mission Statement