Oliver

Oliver

In file 1:

defmodule Utils.Struct do

  # this is for importing definitions when "use Utils.Struct" is called
  defmacro __using__(_opts) do
    quote do
      import Utils.Struct
    end
  end

  defmacro defstruct_module(struct_name, fields) do
    quote do
      defmodule unquote(struct_name) do
        use Utils.Access
        defstruct unquote(fields)
      end
    end
  end

end

In file 2:

defmodule Statistical.Generator do

use Utils.Struct

@in_files [:in_cause, :out_cause, :start]

defstruct_module(State, @in_files)

Breaks:

warning: undefined module attribute @in_files, please remove access to @in_files or explicitly set it before access
  <some file>: Statistical.Generator.State (module)


== Compilation error in file <some file> ==
** (ArgumentError) struct fields definition must be list, got: nil
    (elixir 1.14.4) lib/kernel/utils.ex:117: Kernel.Utils.defstruct/3

But this works - again file 2:

defmodule Statistical.Generator do

use Utils.Struct

@in_files [:in_cause, :out_cause, :start]
in_files = @in_files

defstruct_module(State, in_files)

By the way, if I use the variable approach instead of the module attribute, than the def blocks of the module in file 2 complain… can’t win? :sweat_smile:

Is this because the it inserts the module attribute verbatim as abstract syntax tree? Is there a construct/pattern to handle this case - like would a bind_quote help?

Thank you!

First Post!

DaAnalyst

DaAnalyst

To use the module attributes in your macro, you’ll need to do it in __before_compile__/1.

Take a look at this upgrade of my library which was done precisely for the same reason
(see the difference between v0.2.0 and v0.1.0) - kudos and thanks to @kip

https://github.com/DaTrader/assigns

Most Liked

josevalim

josevalim

Creator of Elixir

Correct. You could instead first unquote it in its actual scope:

    quote do
      fields = unquote(fields)
      defmodule unquote(struct_name) do
        use Utils.Access
        defstruct fields
      end
    end

Last Post!

DaAnalyst

DaAnalyst

If you look at my lib code, you’ll see that in its first version (0.1.0) it simply relied on the vanilla macros to expand the def assign_* and friends. The problem with that approach was that it could only take a list of atoms and not a module attribute (to which a list of atoms is assigned) because the module attribute was not resolvable at the time of the macro expansion. The __before_compile__/1 approach that was suggested by @kip solved this (as shown in the version 0.2.0) because at the time it expands it can resolve the module attributes, hence the necessary refactoring.

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
asweet-confluent
I recently noticed that Elixir’s Logger defaults its primary log level to :debug when no :logger, :level application configuration is pre...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
mhanberg
Hi everyone! The first release candidate for the Expert language server project is now available! We’ve published a press release detai...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New

Latest on Elixir Forum

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews