Nefcairon
Hello,
I am still an Elixir newbie. To learn I keep on asking questions like this…
Can I improve this two functions? It feels like but I do not know how.
defp get_url(team_id) when team_id > 0 do
"a_url_removed_because_not_public" <>
Kernel.inspect(team_id)
end
defp get_url(team_id) when team_id == 0 do
"a_url_removed_because_not_public"
end
besides doing them as one-liners:
defp get_url(team_id) when team_id > 0; do: "a_url_removed_because_not_public" <> Kernel.inspect(team_id)
defp get_url(team_id) when team_id == 0; do: "a_url_removed_because_not_public"
It still looks as it contains too much redundant code.
Where Next?
Trending in Questions
Other Trending Topics
Latest on Elixir Forum
Sponsor Spotlight
Deploy Phoenix to your own VPS with PaaS ease: push-to-deploy, zero downtime, auto SSL, managed Postgres. 14-day free trial at potions.io
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #library
- #deployment
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #discussion
- #code-sync
- #podcasts
- #javascript
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixirconf-us
- #ai
- #blog-post
- #elixir-ls
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #metaprogramming
- #hex
- #security
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Elixir, Erlang & BEAM conferences from Code Sync - join us in 2026!
Practical resources that improve the lives of professional developers.
Master modern tools, write cleaner code, and tackle real-world challenges.
The deployment platform built for Elixir: PaaS ease, VPS control.
The team behind Membrane, Popcorn, LiveDebugger. Available for hire.
Courses that'll move you from confusion to "Aha, now I get it!"
Marked As Solved- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
Qqwy
Quite possibly!
Here are a couple of questions for you, that might help you:
Kernel.inspect(which is meant to only be used for logging/introspection), you probably want to useto_string, or string interpolation. Also, there is no reason to useKernel.in front of a function, because the Kernel module is always (unless explicitly overridden) imported into a module.get_in the name of the function? Depending on the context, this might matter for the meaning of the function name but maybe it is fluff that does not add extra meaning.Also Liked
NobbZ
I’d add a guard
is_integer(team_id)as any non numeric type is greater than 0.Also, I’d use string interpolation rather than inspect.
Inspection in general is something I’d only use for logging, never to create a user facing string.
kokolegorille
You might use
Qqwy
This is not required. And if you really want to put a verb in there,
. Using a verb like
getis about as vague as you can be, since it means so many different thingsgetorfetchas part of a function name would make more sense if you retrieve the URL value from somewhere else. In this case, where it is something the function itself calculates, I would just leave it out:Here, it is clear that
Team.url(foo)will return an URL based onfoothat has to do with a ‘Team’.Of course, naming things quickly enters the realms of personal preference. It is very easy to spend all afternoon bikeshedding about it. It’s possibly the least important suggestion of all of the suggestions that people have given in this topic
.
Last Post!
kokolegorille
It would be fun to do this with GenServer as an exercice but…