smangelsdorf

smangelsdorf

I’ve built a helper function which I was hoping would use streaming to solve the problem of computing the correct coins to make a given total.

A call to do_generate will recursively generate all possible combinations, and return them each as {n, map} where n is the remaining total, and map describes the combination of coins used:

iex(4)> Change.do_generate(100, [12, 5, 1]) |> Enum.to_list |> List.first
{0, %{1 => 4, 12 => 8}}

The function is as follows:

  def do_generate(amount, []), do: [{amount, %{}}]
  def do_generate(amount, [coin | coins]) do
    for n <- div(amount, coin)..0,
        remaining = amount - n * coin,
        {new_amount, map} <- do_generate(remaining, coins),
        do: {new_amount, map |> Map.put(coin, n)}
  end

If I look at the output from do_generate in iex, I see that it’s being fully enumerated:

iex(3)> Change.do_generate(100, [12, 5, 1])
[{0, %{1 => 4, 12 => 8}}, {1, %{1 => 3, 12 => 8}}, {2, %{1 => 2, 12 => 8}},
 {3, %{1 => 1, 12 => 8}}, {4, %{1 => 0, 12 => 8}},
[... snip ...]
 ...]

If I use ~15 coins, the function never returns, because the enumeration is so large. I can get the streaming behaviour I want by changing the second function clause to:

  def do_generate(amount, [coin | coins]) do
    div(amount, coin)..0
    |> Stream.flat_map(fn n ->
      remaining = amount - n * coin
      do_generate(remaining, coins)
      |> Stream.map(fn {new_amount, map} ->
        {new_amount, map |> Map.put(coin, n)}
      end)
    end)
  end
iex(2)> Change.do_generate(100, [12, 5, 1])
#Function<57.77324385/2 in Stream.transform/3>
iex(3)> Change.do_generate(100, [12, 5, 1]) |> Enum.at(0)
{0, %{1 => 4, 5 => 0, 12 => 8}}

It surprised me to hit this issue though, because I found some useful information which made me think my two implementations should be equivalent.

I can’t find the mistake I’ve made which is causing the enumeration.

Showing Posts 1 to 2

benwilson512

benwilson512

Author of Craft GraphQL APIs in Elixir with Absinthe

“equivalent” in the post you linked to I think just means “here’s the code equivalent to what you INTEND”. for is always evaluated eagerly.

smangelsdorf

smangelsdorf OP

That makes perfect sense now that you’ve pointed it out.

Otherwise, the streaming example in the Getting Started guide would need a Stream.run to force evaluation.

Thanks.

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
roeland
Kia ora, We have been using elixir-google-api to connect to Google Drive. However, with the updates to Tesla due to CVEs this is now bro...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
rahultumpala
Hello, I have an Elixir backend that implements a custom protocol over TCP. I want to load test the backend and assess the performance o...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews