smangelsdorf

smangelsdorf

I’ve built a helper function which I was hoping would use streaming to solve the problem of computing the correct coins to make a given total.

A call to do_generate will recursively generate all possible combinations, and return them each as {n, map} where n is the remaining total, and map describes the combination of coins used:

iex(4)> Change.do_generate(100, [12, 5, 1]) |> Enum.to_list |> List.first
{0, %{1 => 4, 12 => 8}}

The function is as follows:

  def do_generate(amount, []), do: [{amount, %{}}]
  def do_generate(amount, [coin | coins]) do
    for n <- div(amount, coin)..0,
        remaining = amount - n * coin,
        {new_amount, map} <- do_generate(remaining, coins),
        do: {new_amount, map |> Map.put(coin, n)}
  end

If I look at the output from do_generate in iex, I see that it’s being fully enumerated:

iex(3)> Change.do_generate(100, [12, 5, 1])
[{0, %{1 => 4, 12 => 8}}, {1, %{1 => 3, 12 => 8}}, {2, %{1 => 2, 12 => 8}},
 {3, %{1 => 1, 12 => 8}}, {4, %{1 => 0, 12 => 8}},
[... snip ...]
 ...]

If I use ~15 coins, the function never returns, because the enumeration is so large. I can get the streaming behaviour I want by changing the second function clause to:

  def do_generate(amount, [coin | coins]) do
    div(amount, coin)..0
    |> Stream.flat_map(fn n ->
      remaining = amount - n * coin
      do_generate(remaining, coins)
      |> Stream.map(fn {new_amount, map} ->
        {new_amount, map |> Map.put(coin, n)}
      end)
    end)
  end
iex(2)> Change.do_generate(100, [12, 5, 1])
#Function<57.77324385/2 in Stream.transform/3>
iex(3)> Change.do_generate(100, [12, 5, 1]) |> Enum.at(0)
{0, %{1 => 4, 5 => 0, 12 => 8}}

It surprised me to hit this issue though, because I found some useful information which made me think my two implementations should be equivalent.

I can’t find the mistake I’ve made which is causing the enumeration.

Showing Posts 1 to 2

benwilson512

benwilson512

Author of Craft GraphQL APIs in Elixir with Absinthe

“equivalent” in the post you linked to I think just means “here’s the code equivalent to what you INTEND”. for is always evaluated eagerly.

smangelsdorf

smangelsdorf OP

That makes perfect sense now that you’ve pointed it out.

Otherwise, the streaming example in the Getting Started guide would need a Stream.run to force evaluation.

Thanks.

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
webofbits
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself. My main conc...
#ai
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews