Muhammad

Muhammad

I would like to refactor the following code.
The first thing that comes to my mind is to extract the case block into a new method,
but maybe there is a better solution?

  def start_conversation(chat_id, user_id, participant) do
    {first_user_id, second_user_id} =
      case participant.gender do
        "female" -> {participant.user_id, user_id}
        "male" -> {user_id, participant.user_id}
      end

    params = %{
      chat_id: chat_id,
      start_time: DateTime.utc_now,
      first_user_id: first_user_id,
      second_user_id: second_user_id
    }
    Db.Conversation.create(params)
  end

Showing Posts 1 to 2

dimitarvp

dimitarvp

Extracting the case statement to a function would also mandate that function have 2 parameters: participant and user_id. And since your case statement is only 5 lines long I don’t think the extraction would make the code better in any way.

I think the code is fine. Do always run mix format though, I’d write DateTime.utc_now() and not DateTime.utc_now – always put parentheses even when calling functions without an argument.

yurko

yurko

I’d split it into few more specific functions so that each of them does less and has less variables, something like this:

def start_conversation(chat_id, user_id, %{gender: "female", user_id: participant_user_id}) do
  create_conversation(chat_id, participant_user_id, user_id)
end

def start_conversation(chat_id, user_id, %{gender: "male", user_id: participant_user_id}) do
  create_conversation(chat_id, user_id, participant_user_id)
end

defp create_conversation(chat_id, first_user_id, second_user_id) do  
  Db.Conversation.create(%{
      chat_id: chat_id,
      start_time: DateTime.utc_now,
      first_user_id: first_user_id,
      second_user_id: second_user_id
    })
end
— All posts loaded —

Where Next? Top

Trending in Questions Top

water
I’m aware of 2 such projects, are there others? git: GitHub - team-alembic/realworld: A fullstack Phoenix LiveView application with back...
New
katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
bradley
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
unaware8150
Hello folks! So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
Alvinkariuki
How Can I Optimise Compile Time Dependencies I have been building an elixir application for about 2 years now. Many modules and files ha...
New

Other Trending Topics Top

budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
budgie
I love Elixir. It’s one of 2 programming languages I’ve ever fallen in love with. But I don’t use it anymore. Serverless was the promis...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews