zambal
Hi, I noticed Absinthe tests failing when using Elixir 1.19.0-rc.2. After some investigation the issue seems to be a change in behaviour of Macro.escape/2 when using the :unquote option. For example, evaluating this expression:
iex> Macro.escape(%{field: {:unquote, [], [:test]}}, unquote: true)
Elixir 1.18: {:%{}, [], [field: :test]}
Elixir 1.19: {:%{}, [], [field: {:{}, [], [:unquote, [], [:test]]}]}
It seems that in 1.19 the unescaping only works when the parent node doesn’t need escaping. Macro.escape([{:unquote, [], [:test]}], unquote: true) for example results in [:test]
I noticed the added line in the documentation “Note this option will give a special meaning to quote/unquote nodes, which need to be valid AST before escaping.”, but to me it’s not entirely clear if this is the intended behaviour, as it is a breaking change, so I was wondering if anybody can confirm this is expected?
Where Next?
Trending in Questions
Other Trending Topics
Latest on Elixir Forum
Sponsor Spotlight
Catch errors, track performance, monitor hosts and more.
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #library
- #deployment
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #discussion
- #code-sync
- #podcasts
- #javascript
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixirconf-us
- #ai
- #blog-post
- #elixir-ls
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #metaprogramming
- #hex
- #security
Our Sponsors
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Error tracking, logs, uptime, and Just Enough APM. Built for developers.
Elixir, Erlang & BEAM conferences from Code Sync - join us in 2026!
Master modern tools, write cleaner code, and tackle real-world challenges.
Producing high quality Elixir screencasts since 2017.
**Building the future of software with AI, trust, and human connection.**
The team behind Membrane, Popcorn, LiveDebugger. Available for hire.
Courses that'll move you from confusion to "Aha, now I get it!"
Showing Posts 1 to 4- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
garrison
I assume this PR is involved? It’s also the source of that docs change.
zambal
Yeah, I’m pretty sure this PR caused the change, but I didn’t have the time to properly look into it in order to be sure if this is intended, so that’s why I asked here.
christhekeele
Oddly enough, wrapping the bare term in a list seems to work:
sabiwara
Woops, good catch @zambal!
Created an issue, Macro.escape/2 doesn't honor :unquote option inside maps on 1.19rc · Issue #14829 · elixir-lang/elixir · GitHub.