Convert json to defstruct definition

Why do you need it to be a struct? Can’t you use a map instead?

I do usually try to avoid to create struct-only modules, so unless you do not want to create related functions, using a plain map might be so much easier.

I was looking at using guards with functions but doesn’t seem like I can use Map.get inside the guard.
I would like to create related functions as well. Can I not make related functions with structs?

You can’t access maps (structs are just sugar over maps) in a guard, but you can match on them in the function head or in a case-clause or using the match operator.

I do not understand that question.

If you’re saying that its easier to use map structures instead, I’m confused as to how one would try to reason about these maps and think in terms of concrete types. In order to create concrete types I’d have to create defstructs.

I do usually try to avoid to create struct-only modules, so unless you do not want to create related functions, using a plain map might be so much easier.

I didn’t quite understand this statement, which prompted my question. You mentioned not creating related functions. Under what conditions can I not make related functions?

I’ll look into the case syntax

I made this some time ago just for shits and giggles: GitHub - GoNZooo/struct_provider: Macro(s) to convert data into struct definitions in Elixir · GitHub

It takes JSON input and creates structs from it. Note that I consider it pretty useless, but if you wanna make something internal from it that’s actually usable for your team, feel free to take and and work out some kinks. As an example of a deficiency, it doesn’t define new modules from nested JSON data, so you’ll only get the top level. The from_json version would probably be a good place to start with and then downloading JSON data to disk as schema for input.

Edit: The reason I find it pretty useless is fundamentally that it’s not backed by statically checked types. If it was, you could know whether your assumptions changed from under you much easier, so then you could pull the data straight from HTTP and generate the types without having to care, because the compiler would always tell you anyway.

I said, that I avoid creating defstruct only modules. If though I have related functions for some type, I do create a module and a defstruct as well. Thats it.

Also JSON doesn’t give you any guarantee about types, so why care?

Creating and maintaining depply nested structs is a burden and comes with a technical debt, when in fact all you need to rely on is the contract that there will be certain fields and you never care for the rest.

This is especially true when you have a JSON which constantly changes its shape and you need to find out the proper type first by checking a certain key in it.

Since your example was to use Map.get in your guard it makes me think you might be able to pattern match instead.

def my_func(%{ data: data }) when is_map(data) do
  ...
end

I completely agree with this.

If using Poison you can have it auto-convert a JSON string to a specific struct(s). You’d still need to write your structs, but once done then you have a confirmed structure.