Interpolation inside a variable?

It’s all still sort of weird though, it’d be much more idiomatic to have the key of the computers map just be the id itself, I don’t see how it helps to have it surrounded by extra atom or string content:

%{
  1 => %Computer{},
  2 => %computer{}, etc
}

Then you can simply look up the computers by id. BUT even this is sort of weird, it would make more sense for the @computers assign to be an ordinary list where the items are simply sorted already into the desired order, and then it can be iterated through as for computer <- @computers do and we skip all of the extra lookups.

It’s usually a bad idea to create atoms dynamically, yes. But in this case I’d argue it’s fine, considering they’re not generated from random user input, but rather a bounded well-defined range.

Could also use String.to_existing_atom to do it without risking the usual problems with dynamically generated atoms.

You can probably do the following:

assigns[String.to_atom("computer#{x}")]

This works because @computer1 is shorthand for assigns.computer1 which can also be expressed as assigns[computer1]