benswift

benswift

The new how to guide on testing resources has some helpful ideas on how to test that actions handle valid inputs.

What’s the recommended way to test that invalid inputs don’t slip through? There’s no Ash.Generator.invalid_action_input/3.

I could just gen all my own invalid inputs (using the “wrong” generator for each attribute) but I wondered if there was a better way?

Showing Posts 1 to 3

zachdaniel

zachdaniel

Creator of Ash

I think the best approach here would be to modify the existing generators with invalid attribute generators. For example:

    property "doesn't accept maps as input to text" do
      user = Domain.create_user!()

      check all(input <- Ash.Generator.action_input(Tweet, :create, %{text: StreamData.fixed_map(%{a: 1})})) do
        {text, other_inputs} = Map.pop!(input, :text)
        Domain.create_tweet!(text, other_inputs, authorize?: false, actor: user)
      end
    end

This particular one is a bit of a silly example, but the point was to illustrate that individual generators can be overridden with generators that produce whatever you like to test specific conditions.

Does that seem like it fits the bill of what you’re looking for?

benswift

benswift OP

Yep, that works - thanks. That’s what I have been doing (except using constant/1 instead of fixed_map/1).

I guess I was wondering if it’s advantageous to have a generator which streams over all the inputs and can provide bad inputs for each attribute one-at-a-time, then shrinks to just the ones which fail. But that might cause a combinatorial explosion of potential cases which isn’t feasible to test.

Anyway, your solution is good and works fine. Thanks :slight_smile:

zachdaniel

zachdaniel

Creator of Ash

Its an interesting idea, but yeah I’ve not done anything fancier than try out specific invalid scenarios that I want to test

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews