jsonify
I’m trying to continue to wrap my brain around how I should be structuring things and I’m getting stuck on the Bob exercise of Exercism. Here is my code and right now, I’m just not understanding why my “Talking in capitals” test isn’t passing like I think it should:
defmodule Bob do
def hey(" "), do: "Fine. Be that way!"
def hey(""), do: "Fine. Be that way!"
def hey(message) do
cond do
shouting?(message) -> "Whoa, chill out!"
asking?(message) -> "Sure."
shout_numbers?(message) -> "Whoa, chill out!"
capitals_letters?(message) -> "Whatever"
# true -> "Whatever."
end
end
defp shouting?(message) do
message == String.upcase(message)
end
defp asking?(message) do
String.ends_with?(message, "?")
end
defp shout_numbers?(message) do
message
|> String.upcase()
String.ends_with?(message, "?")
end
defp capitals_letters?(message) do
message
|> String.split(" ")
|> String.capitalize
Enum.join(" ")
end
end
Where Next?
Trending in Discussions
Other Trending Topics
Chat & Discussions>Discussions
Latest on Elixir Forum
Sponsor Spotlight
Build Elixir applications with speed and confidence.
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #blog-post
- #phoenix_html
- #ai
- #iex
- #graphql
- #elixirconf-us
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #hex
- #security
- #metaprogramming
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Error tracking, logs, uptime, and Just Enough APM. Built for developers.
Develop your skills with books, videos, and courses.
Producing high quality Elixir screencasts since 2017.
Enabling companies to succeed by building software people love.
The team behind Membrane, Popcorn, LiveDebugger. Available for hire.
Courses that'll move you from confusion to "Aha, now I get it!"
Showing Posts 1 to 10- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
NobbZ
Your solution isn’t quite generalized.
You shouldn’t have anything aside of the
cond, as well as there shouldn’t be more than 4 clauses in it, Chill out, be that way, Sure, and Whatever.There is no reason to have any of the strings to be returned at more than one place.
Also your current version of shouting does consider
"1, 2, 3"shout…The cases you need to recognize is if the input was shout (at least one alphabetic character and all alphabetics are in uppercase), if it was a question, if it was silence or if it was none of the former.
themarlzy
Your
capital_letters?function returns a string, whereas I believe you’re after a true/false?Here was my solution which passes the tests, should you want to have a peak.
http://exercism.io/submissions/8314666634e546708d242d5f6d9a06d4
jsonify
While this is still a work in progress, my goal was to get all of the tests to pass first, then refactor while learning more about how to better use Elixir. Thank you for the feedback.
jsonify
How would you have known to use
[\p{L}]in your Regex.match?/2 function? I would NEVER have even begun to figure that one out. Great solution, though.themarlzy
I know a little regex, though, Dr. Google was helpful in this instance.
jsonify
So if I may ask, what exactly did you Google as your search? Did you know that you needed to search for the Unicode solution? Just trying to get a better feel for how one would go about how to figure out how to come to a solution. When I saw your solution, all the pieces made sense and I thought, "of course that makes sense how that was solved. " But it’s the how that conclusion was reached that truly interests me. What steps did you go through to get the results you were looking for.
themarlzy
@jsonify, I will try to break out the process some more
Punctuation regex, yielded this article http://www.regular-expressions.info/posixbrackets.html
That was working well, except it was leaving in $ and ^, so added those on top.
Then it was failing the last test with the diaeresis on the o (ö). It was stripping it off and turning it into a binary e.g.
<<107>>or whatever. Then, after about an hour of trying stuff, I tried the option for unicodeuat the end of the~r/regex/u.Hope that was helpful.
M
Qqwy
Actually, it is possible to fix this Exercise without using regular expressions.
Here is my submission.
That’s right.
all_letters_uppercase?/1checks if upcasing would not change the string, while downcasing would.The logical AND of these statements will return false if either there is a lowercase character, or there are no uppercase-characters at all.
NobbZ
Please link to your submission at exercism, then we could like it or comment.
Qqwy
Of course, how did I forget.
Here is the submission on Exercism.