anotherpit

anotherpit

Nested grafts + Oban.Pro.Workflow.status = Infinite recursion

A graft inside another graft causes Oban.Pro.Workflow.status to recurse forever. oban_pro 1.7.5

defmodule App.NestedGraftRepro.Test do
  # Minimal, self-contained reproduction of an Oban.Pro nested-graft bug (oban_pro 1.7.5).
  #
  # A graft that executes while its own job's `workflow_id` is already "grafted_"-prefixed
  # (i.e. a graft nested inside a grafted workflow) produces a sub-job whose
  # `workflow_id == sup_workflow_id`. `Oban.Pro.Workflow.status/1` walks sub-workflows via
  # `sup_workflow_id -> workflow_id` with no visited-set, so that self-edge makes
  # `expand_status` recurse forever (here: child process killed at max_heap).
  #
  # Topology: 
  # - W -> add_graft(:outer); 
  #   - outer grafts a workflow containing add_graft(:inner); 
  #     - inner grafts a leaf -> leaf.workflow_id == leaf.sup_workflow_id.
  use ExUnit.Case, async: false
  # `prefix: "sunrise"` matches this app's Oban schema; upstream you'd drop it (default "public").
  use Oban.Pro.Testing, repo: App.Repo

  import Ecto.Query

  setup do
    pid = Ecto.Adapters.SQL.Sandbox.start_owner!(App.Repo, shared: true)
    on_exit(fn -> Ecto.Adapters.SQL.Sandbox.stop_owner(pid) end)
    :ok
  end

  defmodule Leaf do
    use Oban.Pro.Worker, queue: :general, max_attempts: 1
    @impl Oban.Pro.Worker
    def process(%Oban.Job{}), do: :ok
  end

  defmodule InnerGrafter do
    use Oban.Pro.Worker, queue: :general, max_attempts: 1

    @impl Oban.Pro.Worker
    def process(%Oban.Job{}) do
      Oban.Pro.Workflow.new()
      |> Oban.Pro.Workflow.add(:leaf, Leaf.new(%{}))
      |> Oban.Pro.Workflow.apply_graft()
      |> Oban.insert_all()

      :ok
    end
  end

  defmodule OuterGrafter do
    use Oban.Pro.Worker, queue: :general, max_attempts: 1

    @impl Oban.Pro.Worker
    def process(%Oban.Job{}) do
      # Graft a workflow that itself contains a graft point -> nesting.
      Oban.Pro.Workflow.new()
      |> Oban.Pro.Workflow.add_graft(:inner, InnerGrafter.new(%{}))
      |> Oban.Pro.Workflow.apply_graft()
      |> Oban.insert_all()

      :ok
    end
  end

  test "nested graft produces workflow_id == sup_workflow_id, and status/1 never terminates" do
    Oban.Testing.with_testing_mode(:manual, fn ->
      Oban.Pro.Workflow.new()
      |> Oban.Pro.Workflow.add_graft(:outer, OuterGrafter.new(%{}))
      |> Oban.insert_all()

      # Recursive drain (default) runs the dynamically-grafted jobs as they're inserted.
      drain_jobs(queue: :general, with_safety: true)

      jobs =
        from(j in Oban.Job,
          select: %{
            name: fragment("?->>'name'", j.meta),
            wid: fragment("?->>'workflow_id'", j.meta),
            sup: fragment("?->>'sup_workflow_id'", j.meta)
          }
        )
        |> App.Repo.all()

      for j <- jobs, do: IO.puts("JOB #{j.name} wid=#{j.wid} sup=#{j.sup}")

      # 1. The broken state: a job whose workflow_id == its own sup_workflow_id.
      selfloop = Enum.find(jobs, fn j -> not is_nil(j.sup) and j.wid == j.sup end)
      assert selfloop, "expected a workflow_id == sup_workflow_id self-loop job, found none"
      IO.puts("SELF-LOOP NODE: name=#{selfloop.name} wid=#{selfloop.wid} sup=#{selfloop.sup}")

      # 2. status/1 on that workflow never returns (infinite expand_status recursion).
      #    Run it in a heap-capped child so the test process survives.
      parent = self()

      {pid, ref} =
        :erlang.spawn_opt(
          fn ->
            result = Oban.Pro.Workflow.status(selfloop.wid)
            send(parent, {:returned, result})
          end,
          [:monitor, {:max_heap_size, %{size: 2_000_000, kill: true, error_logger: false}}]
        )

      outcome =
        receive do
          {:returned, _} -> :returned
          {:DOWN, ^ref, :process, ^pid, reason} -> {:died, reason}
        after
          8_000 ->
            Process.exit(pid, :kill)
            :timeout
        end

      IO.puts("status/1 outcome: #{inspect(outcome)}")

      refute outcome == :returned,
             "status/1 returned — infinite recursion NOT reproduced (bug may be fixed)"
    end)
  end
end

Most Liked

sorenone

sorenone

Oban Core Team

Welcome :waving_hand: @anotherpit,

Thanks for catching a strange edge case and giving us the report. It’s fixed and ready for the next patch release.

Where Next?

Popular in Troubleshooting Top

rathoud96
Environment Elixir 1.18.3-otp-27 / OTP 27.3.4 Oban 2.20.2 Phoenix 1.7.x db_connection 2.8.1 / Postgrex 0.21.1 Infrastructure: Google Cl...
New
ktayah
Environment Oban Pro: 1.7.6 Oban: 2.22.1 Issue When a sub-workflow built with Workflow.put_context/2 is attached to a parent via ...
New
tellemiller
We recently started running Oban with Oban Web on PostgreSQL (AWS RDS gp3) and noticed our oban_jobs buffer cache hit ratio sitting at 65...
New
rayex
When I compile hex package io_ansi_plus, I get error “Codepoint failed”. Why? and why are the “Got:” and “Hint:” codepoints identical? It...
New
AstraLuma
Experienced programmer writer her first Elixir, and maybe bit off more than she can chew? I’m trying to start two GenServers, where the ...
New
rayex
For hex package islands_score the source @spec for function format/2 is as such: @spec format(t, keyword) :: :ok Why does it show on 4 ...
New
anotherpit
A graft inside another graft causes Oban.Pro.Workflow.status to recurse forever. oban_pro 1.7.5 defmodule App.NestedGraftRepro.Test do ...
New
bugnano
Hello everyone. I’m the author of GitHub - bugnano/wtransport-elixir: Elixir bindings for the WTransport WebTransport library · GitHub ,...
New
Lotoen
Hi, I’m on Linux Mint 22.3 - Cinnamon 64-bit, and I encountered an error when trying to build an elixir phoenix container 577.1 Reading...
New
ndan
Oban.Pro.Migration.up(version: "1.7.0", only: :indexes) fails on partitioned oban_jobs table when upgrading Oban Pro from 1.6 to 1.7 def...
New

Other popular topics Top

danschultzer
None of the current solutions worked well for me, so I went ahead and built a user management system from scratch. This project took far...
548 29377 241
New
lastday4you
I wanted to check elixir version in phoenix because i found that my elixir is 1.5 but when i use Enum.chunk_by it said the function is un...
New
lessless
I believe there are people here who are dealing with CSV files import on the daily basis, and since Excel is a really popular tool there ...
New
msaraiva
Surface is an experimental library built on top of Phoenix LiveView and its new LiveComponent API that aims to provide a more declarative...
564 43622 214
New
dokuzbir
I want to highlight html closing tags when i click a html tag. That works in .html files but doesnt work for html.eex templates. How can...
New
alice
Hey, Just curious what are the main benefits of Elixir compared to Clojure? When is Elixir more useful than Clojure and vice versa? Th...
New
klo
Got a question about when to concat vs. prepending items to list then reversing to achieve appending. So i know lists boil down to [1 | ...
New
komlanvi
Hi everyone, I was playing with phoenix liveView but I run into an issue. I have a form and want to validate each input text when the te...
New
marick
I had some trouble figuring out how to make many-to-many associations work. Once I got it working, I wrote a blog post. Because I’m a nov...
New
sergio
Kind of like when jquery came out, it was super necessary. Existing drag and drop libraries have a bunch of baggage to support old browse...
New

We're in Beta

About us Mission Statement