Kapeusz

Kapeusz

Hello, I have a problem with properly understanding Enum.reduce but after many tries I managed to get this inside my function to work. However, when I run mix credo --strict I see there’s a refactoring opportunity because the function body is nested too deep. Could you please help me with refactoring this function? I would appreciate an additional explanation. Thank you!

    Enum.reduce(conditions, queryable, fn {k, v}, acc ->
      case {k, v} do
        {_, ""} ->
          acc

        {_, _} when is_atom(k) ->
          case {k in like_fields, k in date_fields} do
            {true, false} -> where_ilike(acc, k, v)
            {false, true} -> where_date(acc, k, v)
            {false, false} -> where(acc, [u], field(u, ^k) == ^v)
          end

        _ ->
          acc
      end
    end)

Showing Posts 1 to 1

josevalim

josevalim

Creator of Elixir

Note that the branching and pattern matching can also be applied to fn and are equivalent:

    Enum.reduce(conditions, queryable, fn
      {_, ""}, acc ->
        acc

      {k, v}, acc when is_atom(k) ->
        case {k in like_fields, k in date_fields} do
          {true, false} -> where_ilike(acc, k, v)
          {false, true} -> where_date(acc, k, v)
          {false, false} -> where(acc, [u], field(u, ^k) == ^v)
        end

      _, acc ->
        acc
    end)

You can also merge the first and third branches:

    Enum.reduce(conditions, queryable, fn
      {k, v}, acc when is_atom(k) and v != "" ->
        case {k in like_fields, k in date_fields} do
          {true, false} -> where_ilike(acc, k, v)
          {false, true} -> where_date(acc, k, v)
          {false, false} -> where(acc, [u], field(u, ^k) == ^v)
        end

      _, acc ->
        acc
    end)
— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kpanic
Hi everyone, I am toying with the idea of building a “match maker” for giving personal help to people that wants to start coding. I sta...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
asweet-confluent
I recently noticed that Elixir’s Logger defaults its primary log level to :debug when no :logger, :level application configuration is pre...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
mhanberg
Hi everyone! The first release candidate for the Expert language server project is now available! We’ve published a press release detai...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
webofbits
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself. My main conc...
#ai
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews