mau013
Hi everyone,
I have just added Credo to my project and I really liked it. I would like to take it a step further and implement further checks via plugins but I’m struggling to find a list of them… so my questions for you all are:
- Which Credo plugins are you using (if any)?
- Is the community gravitating towards a common set of checks other than those included in Credo itself?
Thanks a ton for any help.
Where Next?
Trending in Questions
Other Trending Topics
Latest on Elixir Forum
Sponsor Spotlight
Phoenix, LiveView, multimedia pipelines, distributed systems. 400 engineers, Elixir since 2017. Available for hire.
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #library
- #deployment
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #discussion
- #code-sync
- #podcasts
- #javascript
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #ai
- #elixirconf-us
- #blog-post
- #elixir-ls
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #elixirconf-eu
- #metaprogramming
- #hex
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Error tracking, logs, uptime, and Just Enough APM. Built for developers.
Practical resources that improve the lives of professional developers.
Master modern tools, write cleaner code, and tackle real-world challenges.
Producing high quality Elixir screencasts since 2017.
The team behind Membrane, Popcorn, LiveDebugger. Available for hire.
Courses that'll move you from confusion to "Aha, now I get it!"
Showing Posts 18 to 9- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
slouchpie
A lib called ‘styler’ can fix those things.
apoorv-2204
is there any way that credo issue can be fixed automatically. like
what can be fixed.
Like fx instead of fx()
and ordering of aliases?
sodapopcan
That would certainly also work, the Credo plugin is just there so I use it.
D4no0
What about removing the default option and raising an error if no option is given?
sodapopcan
Ya, it’s definitely totally fine to do that. I just like the Credo rule as it’s the least surprising thing. When I worked on a codebase where
async: truewas the default, I was unaware of that fact for a bit so I would put it anyway. Not a huge deal, but it causes inconsistencies. It’s also possible (though unlikely) that someone could be writing a test that needs to not be async and they think it is. This is all very, very minor stuff and can be solved with good communication (though we all know that can go). In any event, being required to put it just takes anything like that right out of the equation.warmwaffles
Actually that’s a way better idea to default to true and have people explicitly state it as false. Why did that never occur to me?
mau013
Super useful article! Just bookmarked it for future reference. Thanks for sharing.
Seems like there are some useful checks there. Currently I’m working solo, so it’s a bit easier to achieve consensus (mostly just a handful of demons are awake in my head at a time
).
sodapopcan
That’s my point, that it forces you to specify either
trueorfalse. A lot of people just make it default totrueinConn.Casebut I don’t really love that either and prefer to always see the explicitly given option.EDIT: Maybe that’s what you’re saying… better to just default to
trueand you then it’s clear that when you specifyfalseit was intentional?warmwaffles
So for our code base we have a few situations where
asyncis not possible (modification of application config) and we have thesetupblock raise. In other cases I have been debating just emitting a warning to annoy devs to make them async. In some cases, it just is not possible to make async. But overall, most can be.dimitarvp
I dislike the raw SQL check myself but the rest I actually like. IMO just discuss with the team. I always recommend the maximum amount of checks and then we just disable whatever ends up being annoying or giving too many false positives.